Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2580873002: [Payments] Refactor how shipping and contact detail sections are created (Closed)

Created:
4 years ago by sebsg
Modified:
4 years ago
CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Refactor how shipping and contact detail sections are created BUG=674571 Committed: https://crrev.com/33696dd10f1c34ba233a8363d0b42f8b45962d16 Cr-Commit-Position: refs/heads/master@{#438895}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Moved method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -98 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 2 chunks +108 lines, -98 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
sebsg
Hi Rouslan, PTAL?
4 years ago (2016-12-15 16:16:02 UTC) #4
please use gerrit instead
lgtm % comment https://codereview.chromium.org/2580873002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java File chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java (right): https://codereview.chromium.org/2580873002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java#newcode1324 chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:1324: private void createShippingSection(List<AutofillProfile> profiles) { The ...
4 years ago (2016-12-15 17:49:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580873002/20001
4 years ago (2016-12-15 19:02:33 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-15 19:38:30 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-15 19:42:16 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/33696dd10f1c34ba233a8363d0b42f8b45962d16
Cr-Commit-Position: refs/heads/master@{#438895}

Powered by Google App Engine
This is Rietveld 408576698