Issue 258083004: Trusted plugin: Remove EnumerateManifestKeys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 258083004: Trusted plugin: Remove EnumerateManifestKeys. (Closed)

Created:
6 years, 7 months ago by teravest

Modified:
6 years, 7 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Trusted plugin: Remove EnumerateManifestKeys. This function was removed from ReverseService inside "native_client/", as it's no longer necessary. This change removes an implementation that's never called, and simplifies the Manifest logic, making it easier to move that out of the trusted plugin. BUG=239656 R=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266938

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -40 lines)			Patch
M	ppapi/native_client/src/trusted/plugin/json_manifest.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/json_manifest.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/manifest.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/258083004/1

6 years, 7 months ago (2014-04-29 17:13:07 UTC) #4

teravest

6 years, 7 months ago (2014-04-29 19:43:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r266938 (presubmit successful).

Expand Messages | Collapse Messages