Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Side by Side Diff: ppapi/native_client/src/trusted/plugin/service_runtime.cc

Issue 258083004: Trusted plugin: Remove EnumerateManifestKeys. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ppapi/native_client/src/trusted/plugin/service_runtime.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 * Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 * Use of this source code is governed by a BSD-style license that can be 3 * Use of this source code is governed by a BSD-style license that can be
4 * found in the LICENSE file. 4 * found in the LICENSE file.
5 */ 5 */
6 6
7 #define NACL_LOG_MODULE_NAME "Plugin_ServiceRuntime" 7 #define NACL_LOG_MODULE_NAME "Plugin_ServiceRuntime"
8 8
9 #include "ppapi/native_client/src/trusted/plugin/service_runtime.h" 9 #include "ppapi/native_client/src/trusted/plugin/service_runtime.h"
10 10
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 void PluginReverseInterface::PostMessage_MainThreadContinuation( 177 void PluginReverseInterface::PostMessage_MainThreadContinuation(
178 PostMessageResource* p, 178 PostMessageResource* p,
179 int32_t err) { 179 int32_t err) {
180 UNREFERENCED_PARAMETER(err); 180 UNREFERENCED_PARAMETER(err);
181 NaClLog(4, 181 NaClLog(4,
182 "PluginReverseInterface::PostMessage_MainThreadContinuation(%s)\n", 182 "PluginReverseInterface::PostMessage_MainThreadContinuation(%s)\n",
183 p->message.c_str()); 183 p->message.c_str());
184 plugin_->PostMessage(std::string("DEBUG_POSTMESSAGE:") + p->message); 184 plugin_->PostMessage(std::string("DEBUG_POSTMESSAGE:") + p->message);
185 } 185 }
186 186
187 bool PluginReverseInterface::EnumerateManifestKeys(
188 std::set<nacl::string>* out_keys) {
189 return manifest_->GetFileKeys(out_keys);
190 }
191
192 // TODO(bsy): OpenManifestEntry should use the manifest to ResolveKey 187 // TODO(bsy): OpenManifestEntry should use the manifest to ResolveKey
193 // and invoke StreamAsFile with a completion callback that invokes 188 // and invoke StreamAsFile with a completion callback that invokes
194 // GetPOSIXFileDesc. 189 // GetPOSIXFileDesc.
195 bool PluginReverseInterface::OpenManifestEntry(nacl::string url_key, 190 bool PluginReverseInterface::OpenManifestEntry(nacl::string url_key,
196 struct NaClFileInfo* info) { 191 struct NaClFileInfo* info) {
197 bool op_complete = false; // NB: mu_ and cv_ also controls access to this! 192 bool op_complete = false; // NB: mu_ and cv_ also controls access to this!
198 // The to_open object is owned by the weak ref callback. Because this function 193 // The to_open object is owned by the weak ref callback. Because this function
199 // waits for the callback to finish, the to_open object will be deallocated on 194 // waits for the callback to finish, the to_open object will be deallocated on
200 // the main thread before this function can return. The pointers it contains 195 // the main thread before this function can return. The pointers it contains
201 // to stack variables will not leak. 196 // to stack variables will not leak.
(...skipping 599 matching lines...) Expand 10 before | Expand all | Expand 10 after
801 796
802 nacl::string ServiceRuntime::GetCrashLogOutput() { 797 nacl::string ServiceRuntime::GetCrashLogOutput() {
803 if (NULL != subprocess_.get()) { 798 if (NULL != subprocess_.get()) {
804 return subprocess_->GetCrashLogOutput(); 799 return subprocess_->GetCrashLogOutput();
805 } else { 800 } else {
806 return std::string(); 801 return std::string();
807 } 802 }
808 } 803 }
809 804
810 } // namespace plugin 805 } // namespace plugin
OLDNEW
« no previous file with comments | « ppapi/native_client/src/trusted/plugin/service_runtime.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698