Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2580823003: Rename snapshot kind enum values kAppWithJIT -> kAppJIT, kAppNoJIT -> kAppAOT. (Closed)

Created:
4 years ago by rmacnak
Modified:
4 years ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename snapshot kind enum values (kAppWithJIT -> kAppJIT, kAppNoJIT -> kAppAOT). R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/dc426c8c522e14d5e34a522950aba11365237d2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -80 lines) Patch
M runtime/vm/clustered_snapshot.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/clustered_snapshot.cc View 23 chunks +32 lines, -32 lines 0 comments Download
M runtime/vm/dart.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/megamorphic_cache_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M runtime/vm/object_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/pages.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/precompiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/raw_object.h View 5 chunks +10 lines, -10 lines 0 comments Download
M runtime/vm/snapshot.h View 2 chunks +13 lines, -13 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
rmacnak
4 years ago (2016-12-15 19:03:35 UTC) #4
Florian Schneider
lgtm
4 years ago (2016-12-15 19:13:37 UTC) #5
rmacnak
4 years ago (2016-12-15 20:16:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dc426c8c522e14d5e34a522950aba11365237d2d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698