Split the CSSParserContext class out of CSSParserMode into its own file.

Split the CSSParserContext class out of CSSParserMode into its own file.

This is a refactor only, no functionality should change. This moves
CSSParserContext into its own file and resolves now-missing transitive
dependencies, in anticipation of further refactoring.

TBR=rune@opera.com
BUG=668251
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/709fea37a6942d33a32c49f5b42193ac40ef099e
Cr-Commit-Position: refs/heads/master@{#440214}

[Bret, 2016-12-17 01:03:30]

Description was changed from

==========
Split the CSSParserContext class out of CSSParserMode into its own file.

This is a refactor only, no functionality should change. This moves
CSSParserContext into its own file and resolves now-missing transitive
dependencies, in anticipation of further refactoring.

BUG=668251
==========

to

==========
Split the CSSParserContext class out of CSSParserMode into its own file.

This is a refactor only, no functionality should change. This moves
CSSParserContext into its own file and resolves now-missing transitive
dependencies, in anticipation of further refactoring.

BUG=668251
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Bret, 2016-12-17 01:04:00]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-17 01:04:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 01:07:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-17 01:07:21]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Bret, 2016-12-17 01:48:49]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-17 01:49:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 02:07:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-17 02:07:22]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[Bret, 2016-12-17 02:14:45]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-17 02:15:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 04:02:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-17 04:02:26]

Dry run: This issue passed the CQ dry run.

[Bret, 2016-12-19 19:23:21]

Description was changed from

==========
Split the CSSParserContext class out of CSSParserMode into its own file.

This is a refactor only, no functionality should change. This moves
CSSParserContext into its own file and resolves now-missing transitive
dependencies, in anticipation of further refactoring.

BUG=668251
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Split the CSSParserContext class out of CSSParserMode into its own file.

This is a refactor only, no functionality should change. This moves
CSSParserContext into its own file and resolves now-missing transitive
dependencies, in anticipation of further refactoring.

BUG=668251
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Bret, 2016-12-19 19:23:22]

bsep@chromium.org changed reviewers:
+ rune@opera.com

[Bret, 2016-12-19 19:25:39]

I touched files outside core/css but they are simple include changes. Do you
feel comfortable approving those changes too?

[rune, 2016-12-19 20:34:17]

In general I think we should prefer forward declarations to includes when
possible. Compiling Chromium is way too slow already.

https://codereview.chromium.org/2580793005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/FontFaceSet.cpp (right):

https://codereview.chromium.org/2580793005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/FontFaceSet.cpp:449:
static_cast<StyleSheetContents*>(nullptr));
Do you need the static_cast?

https://codereview.chromium.org/2580793005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSParserContext.h (right):

https://codereview.chromium.org/2580793005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSParserContext.h:9: #include
"core/dom/Document.h"
Why do you need this? Couldn't you have kept the forward declaration of Document
instead?

https://codereview.chromium.org/2580793005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.h
(left):

https://codereview.chromium.org/2580793005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.h:35: class
CSSParserContext;
Why not keep the forward declaration instead of adding the include?

[Bret, 2016-12-20 01:26:58]

I did an audit of the includes I added. I changed a few to forward declarations
but most were necessary.

https://codereview.chromium.org/2580793005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/FontFaceSet.cpp (right):

https://codereview.chromium.org/2580793005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/FontFaceSet.cpp:449:
static_cast<StyleSheetContents*>(nullptr));
On 2016/12/19 20:34:17, rune wrote:
> Do you need the static_cast?

No, reverted. Sorry, this was left over from me splitting CLs.

https://codereview.chromium.org/2580793005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSParserContext.h (right):

https://codereview.chromium.org/2580793005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSParserContext.h:9: #include
"core/dom/Document.h"
On 2016/12/19 20:34:17, rune wrote:
> Why do you need this? Couldn't you have kept the forward declaration of
Document
> instead?

I might have to make this a full include in a later patch. But right now this is
due to CL splitting, so reverted.

https://codereview.chromium.org/2580793005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.h
(left):

https://codereview.chromium.org/2580793005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.h:35: class
CSSParserContext;
On 2016/12/19 20:34:17, rune wrote:
> Why not keep the forward declaration instead of adding the include?

Sorry, I thought we wanted to replace forward declarations with includes,
instead of the other way around. So I reverted this change.

[rune, 2016-12-20 07:21:14]

lgtm

[Bret, 2016-12-20 19:42:27]

The CQ bit was checked by bsep@chromium.org

[commit-bot: I haz the power, 2016-12-20 19:43:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 20:05:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 20:05:09]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Bret, 2016-12-21 00:05:49]

The CQ bit was checked by bsep@chromium.org

[Bret, 2016-12-21 00:05:50]

The patchset sent to the CQ was uploaded after l-g-t-m from rune@opera.com
Link to the patchset: https://codereview.chromium.org/2580793005/#ps80001
(title: "fix linux compile")

[commit-bot: I haz the power, 2016-12-21 00:06:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 00:45:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 00:45:48]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Bret, 2016-12-21 01:49:53]

The CQ bit was checked by bsep@chromium.org

[Bret, 2016-12-21 01:49:54]

The patchset sent to the CQ was uploaded after l-g-t-m from rune@opera.com
Link to the patchset: https://codereview.chromium.org/2580793005/#ps100001
(title: "fix compile")

[commit-bot: I haz the power, 2016-12-21 01:50:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 02:02:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 02:02:10]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Bret, 2016-12-21 21:06:44]

Description was changed from

==========
Split the CSSParserContext class out of CSSParserMode into its own file.

This is a refactor only, no functionality should change. This moves
CSSParserContext into its own file and resolves now-missing transitive
dependencies, in anticipation of further refactoring.

BUG=668251
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Split the CSSParserContext class out of CSSParserMode into its own file.

This is a refactor only, no functionality should change. This moves
CSSParserContext into its own file and resolves now-missing transitive
dependencies, in anticipation of further refactoring.

TBR=rune@opera.com
BUG=668251
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Bret, 2016-12-21 21:09:28]

The CQ bit was checked by bsep@chromium.org

[commit-bot: I haz the power, 2016-12-21 21:10:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 21:16:45]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1482354568271120,
"parent_rev": "ec014027766f3e7961b23f46e84cc2d727d3eb97", "commit_rev":
"9af1192cd77a2811d6a7c6cf8ec3e018be31570c"}

[commit-bot: I haz the power, 2016-12-21 21:17:13]

Description was changed from

==========
Split the CSSParserContext class out of CSSParserMode into its own file.

This is a refactor only, no functionality should change. This moves
CSSParserContext into its own file and resolves now-missing transitive
dependencies, in anticipation of further refactoring.

TBR=rune@opera.com
BUG=668251
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Split the CSSParserContext class out of CSSParserMode into its own file.

This is a refactor only, no functionality should change. This moves
CSSParserContext into its own file and resolves now-missing transitive
dependencies, in anticipation of further refactoring.

TBR=rune@opera.com
BUG=668251
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2580793005
==========

[commit-bot: I haz the power, 2016-12-21 21:17:15]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-21 21:19:27]

Description was changed from

==========
Split the CSSParserContext class out of CSSParserMode into its own file.

This is a refactor only, no functionality should change. This moves
CSSParserContext into its own file and resolves now-missing transitive
dependencies, in anticipation of further refactoring.

TBR=rune@opera.com
BUG=668251
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2580793005
==========

to

==========
Split the CSSParserContext class out of CSSParserMode into its own file.

This is a refactor only, no functionality should change. This moves
CSSParserContext into its own file and resolves now-missing transitive
dependencies, in anticipation of further refactoring.

TBR=rune@opera.com
BUG=668251
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/709fea37a6942d33a32c49f5b42193ac40ef099e
Cr-Commit-Position: refs/heads/master@{#440214}
==========

[commit-bot: I haz the power, 2016-12-21 21:19:28]

Patchset 6 (id:??) landed as
https://crrev.com/709fea37a6942d33a32c49f5b42193ac40ef099e
Cr-Commit-Position: refs/heads/master@{#440214}