Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1406)

Unified Diff: content/browser/service_worker/service_worker_url_request_job.cc

Issue 2580793004: service worker: Add CHECKs for investigating null http info bug. (Closed)
Patch Set: Fix foreign fetch Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_url_request_job.cc
diff --git a/content/browser/service_worker/service_worker_url_request_job.cc b/content/browser/service_worker/service_worker_url_request_job.cc
index 69e06770eaa95417da987bcc79f0b26286d887c1..05b69eda5f326efec5d23894408efe2a3bb29999 100644
--- a/content/browser/service_worker/service_worker_url_request_job.cc
+++ b/content/browser/service_worker/service_worker_url_request_job.cc
@@ -587,7 +587,8 @@ void ServiceWorkerURLRequestJob::DidDispatchFetchEvent(
}
// We should have a response now.
- DCHECK_EQ(SERVICE_WORKER_FETCH_EVENT_RESULT_RESPONSE, fetch_result);
+ // TODO(falken): Turn to DCHECK once https://crbug.com/485900 is resolved.
+ CHECK_EQ(SERVICE_WORKER_FETCH_EVENT_RESULT_RESPONSE, fetch_result);
// A response with status code 0 is Blink telling us to respond with network
// error.
@@ -608,6 +609,7 @@ void ServiceWorkerURLRequestJob::DidDispatchFetchEvent(
DCHECK(version);
const net::HttpResponseInfo* main_script_http_info =
version->GetMainScriptHttpResponseInfo();
+ CHECK(main_script_http_info);
if (main_script_http_info) {
// In normal case |main_script_http_info| must be set while starting the
// ServiceWorker. But when the ServiceWorker registration database was not

Powered by Google App Engine
This is Rietveld 408576698