Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2580793003: Remove stl_util's deletion functions. (Closed)

Created:
4 years ago by Avi (use Gerrit)
Modified:
4 years ago
Reviewers:
brettw
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stl_util's deletion functions. BUG=555865 Committed: https://crrev.com/23840067cb39c3936141e602dd408e9eea9d57dc Cr-Commit-Position: refs/heads/master@{#439134}

Patch Set 1 #

Patch Set 2 : presub #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M PRESUBMIT.py View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M base/stl_util.h View 1 2 1 chunk +0 lines, -20 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (13 generated)
Avi (use Gerrit)
Alternately this one.
4 years ago (2016-12-15 21:36:28 UTC) #6
brettw
lgtm
4 years ago (2016-12-15 22:11:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580793003/20001
4 years ago (2016-12-16 01:42:46 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/357574)
4 years ago (2016-12-16 02:29:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580793003/40001
4 years ago (2016-12-16 15:32:00 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-16 17:28:36 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-16 17:31:27 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/23840067cb39c3936141e602dd408e9eea9d57dc
Cr-Commit-Position: refs/heads/master@{#439134}

Powered by Google App Engine
This is Rietveld 408576698