Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc

Issue 2580773003: Blacklist method names without considering static-vs-instance. (Closed)
Patch Set: Stop blacklisting the |trace| method instead. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc b/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
index 28020337bb25359f3d6a8622660954de551b975d..3e85018cb57b95dcb1d21b8a8985323ef7f412f6 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
@@ -58,7 +58,8 @@ class Task {
my_iterator end() {}
my_iterator rbegin() {}
MyIterator rend() {}
- // The trace() method is used by Oilpan, we shouldn't rename it.
+ // The trace() method is used by Oilpan, but we plan to tweak the Oilpan's
+ // clang plugin, so that it recognizes the new method name.
void trace() {}
// These are used by std::unique_lock and std::lock_guard.
void lock() {}
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698