Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc

Issue 2580773003: Blacklist method names without considering static-vs-instance. (Closed)
Patch Set: Stop blacklisting the |trace| method instead. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc b/tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc
index f770362855c353fb14b5ca55373c9718ee1cc6dc..4cbdc0e1fd0d64606877222761ba1bf93dbc46af 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc
@@ -54,8 +54,9 @@ class Task {
my_iterator end() {}
my_iterator rbegin() {}
MyIterator rend() {}
- // The trace() method is used by Oilpan, we shouldn't rename it.
- void trace() {}
+ // The trace() method is used by Oilpan, but we plan to tweak the Oilpan's
+ // clang plugin, so that it recognizes the new method name.
+ void Trace() {}
// These are used by std::unique_lock and std::lock_guard.
void lock() {}
void unlock() {}

Powered by Google App Engine
This is Rietveld 408576698