Disable No-State prefetch for offline origins.

Disable No-State prefetch for offline origins.

BUG=674181
Committed: https://crrev.com/0145a58dcc272c1d55f51c3676261e65d5c37394
Cr-Commit-Position: refs/heads/master@{#439135}

[droger, 2016-12-16 13:25:13]

The CQ bit was checked by droger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 13:25:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[droger, 2016-12-16 13:25:29]

Description was changed from

==========
Disable No-State prefetch for offline origins.
==========

to

==========
Disable No-State prefetch for offline origins.

BUG=674181
==========

[droger, 2016-12-16 13:32:36]

droger@chromium.org changed reviewers:
+ pasko@chromium.org

[droger, 2016-12-16 13:35:33]

CC dougarnett, mattcary

[commit-bot: I haz the power, 2016-12-16 14:16:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 14:16:42]

Dry run: This issue passed the CQ dry run.

[droger, 2016-12-16 16:47:36]

pasko: Please send to CQ if this looks good.

[pasko, 2016-12-16 17:22:59]

The CQ bit was checked by pasko@chromium.org

[pasko, 2016-12-16 17:23:00]

lgtm

https://codereview.chromium.org/2580753005/diff/1/chrome/browser/prerender/pr...
File chrome/browser/prerender/prerender_manager.cc (right):

https://codereview.chromium.org/2580753005/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_manager.cc:962: prefetches_.emplace_back(url,
GetCurrentTimeTicks(), origin);
Just to double-check that I understand: modifying the prefetches_ is OK here
because they are used only for histograms, and we would just ignore the
prefetches_-based histograms for these two origins?

[commit-bot: I haz the power, 2016-12-16 17:23:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 17:34:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481908979763550, "parent_rev":
"bdc2fe2b6501a41242a88bb831265f673194c300", "commit_rev":
"26752db3b05f4b0bad1e95044d4074a17f87f017"}

[commit-bot: I haz the power, 2016-12-16 17:34:27]

Description was changed from

==========
Disable No-State prefetch for offline origins.

BUG=674181
==========

to

==========
Disable No-State prefetch for offline origins.

BUG=674181

Review-Url: https://codereview.chromium.org/2580753005
==========

[commit-bot: I haz the power, 2016-12-16 17:34:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-16 17:36:35]

Description was changed from

==========
Disable No-State prefetch for offline origins.

BUG=674181

Review-Url: https://codereview.chromium.org/2580753005
==========

to

==========
Disable No-State prefetch for offline origins.

BUG=674181

Committed: https://crrev.com/0145a58dcc272c1d55f51c3676261e65d5c37394
Cr-Commit-Position: refs/heads/master@{#439135}
==========

[commit-bot: I haz the power, 2016-12-16 17:36:36]

Patchset 1 (id:??) landed as
https://crrev.com/0145a58dcc272c1d55f51c3676261e65d5c37394
Cr-Commit-Position: refs/heads/master@{#439135}

[droger, 2016-12-16 18:35:47]

Thanks.

https://codereview.chromium.org/2580753005/diff/1/chrome/browser/prerender/pr...
File chrome/browser/prerender/prerender_manager.cc (right):

https://codereview.chromium.org/2580753005/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_manager.cc:962: prefetches_.emplace_back(url,
GetCurrentTimeTicks(), origin);
On 2016/12/16 17:23:00, pasko wrote:
> Just to double-check that I understand: modifying the prefetches_ is OK here
> because they are used only for histograms, and we would just ignore the
> prefetches_-based histograms for these two origins?

Yes, exactly.

This messes up our metrics a bit but luckily most (all?) our histograms are
split by origin and we can easily exclude these.

[chromium-reviews, 2016-12-16 19:03:19]

Thanks!

On Fri, Dec 16, 2016 at 10:35 AM <droger@chromium.org> wrote:

> Thanks.
>
>
>
>
>
https://codereview.chromium.org/2580753005/diff/1/chrome/browser/prerender/pr...
> File chrome/browser/prerender/prerender_manager.cc (right):
>
>
>
https://codereview.chromium.org/2580753005/diff/1/chrome/browser/prerender/pr...
> chrome/browser/prerender/prerender_manager.cc:962:
> prefetches_.emplace_back(url, GetCurrentTimeTicks(), origin);
> On 2016/12/16 17:23:00, pasko wrote:
> > Just to double-check that I understand: modifying the prefetches_ is
> OK here
> > because they are used only for histograms, and we would just ignore
> the
> > prefetches_-based histograms for these two origins?
>
> Yes, exactly.
>
> This messes up our metrics a bit but luckily most (all?) our histograms
> are split by origin and we can easily exclude these.
>
> https://codereview.chromium.org/2580753005/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.