Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2580743002: Worker: Clarify a target context of postTask in WorkerEventQueue (Closed)

Created:
4 years ago by nhiroki
Modified:
4 years ago
Reviewers:
tzik
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Clarify a target context of postTask in WorkerEventQueue BUG=673711 Committed: https://crrev.com/ce453d62d03c14d69988ddc3649ab667ac421210 Cr-Commit-Position: refs/heads/master@{#438805}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use ExecutionContext::postTask #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M third_party/WebKit/Source/core/workers/WorkerEventQueue.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp View 1 3 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
nhiroki
ptal, thanks
4 years ago (2016-12-15 06:29:24 UTC) #4
tzik
https://codereview.chromium.org/2580743002/diff/1/third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp File third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp (right): https://codereview.chromium.org/2580743002/diff/1/third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp#newcode67 third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp:67: String()); Could you add `using ExecutionContext::postTask` to WorkerGlobalScope, and ...
4 years ago (2016-12-15 08:34:19 UTC) #7
nhiroki
Thank you for reviewing. Updated. https://codereview.chromium.org/2580743002/diff/1/third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp File third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp (right): https://codereview.chromium.org/2580743002/diff/1/third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp#newcode67 third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp:67: String()); On 2016/12/15 08:34:19, ...
4 years ago (2016-12-15 09:15:16 UTC) #8
tzik
lgtm
4 years ago (2016-12-15 09:32:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580743002/20001
4 years ago (2016-12-15 09:55:05 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-15 11:36:16 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-15 11:38:28 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ce453d62d03c14d69988ddc3649ab667ac421210
Cr-Commit-Position: refs/heads/master@{#438805}

Powered by Google App Engine
This is Rietveld 408576698