[SPInvalidation] Update paint properties on perspective etc. change

[SPInvalidation] Update paint properties on perspective etc. change

BUG=645667
TEST=virtual/spinvalidation/paint/invalidation/perspective.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/3446d1745a09854682d54031e433429d68589fce
Cr-Commit-Position: refs/heads/master@{#439319}

[Xianzhu, 2016-12-16 21:09:23]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 21:10:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 23:00:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 23:00:56]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2016-12-16 23:06:15]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[Xianzhu, 2016-12-16 23:06:16]

https://codereview.chromium.org/2580713005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp (right):

https://codereview.chromium.org/2580713005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp:312:
hadTransformRelatedProperty != hasTransformRelatedProperty()) {
I haven't found a test case failing without the above change, perhaps because
there are other paths also setNeedsPaintPropertyUpdate() on change of
preserve-3d, will-change: transform, but I think this can be a fail-safe and is
consistent with what we do in property update.

[pdr., 2016-12-16 23:20:57]

LGTM

Could you make the test a unittest and check the resulting properties, or do you
think there's value in the layer bounds output?

[Xianzhu, 2016-12-17 02:24:27]

Description was changed from

==========
[SPInvalidation] Update paint properties on perspective etc. change

BUG=645667
TEST=virtual/spinvalidation/paint/invalidation/perspective.html
==========

to

==========
[SPInvalidation] Update paint properties on perspective etc. change

BUG=645667
TEST=virtual/spinvalidation/paint/invalidation/perspective.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-17 02:26:36]

On 2016/12/16 23:20:57, pdr. wrote:
> LGTM
> 
> Could you make the test a unittest and check the resulting properties, or do
you
> think there's value in the layer bounds output?

Done.

Added test in the existing PaintPropertyTreeBuilderTest.Perspective. Inlined the
test source.

[Xianzhu, 2016-12-17 02:27:42]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-12-17 02:27:42]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2580713005/#ps20001
(title: "Unit test")

[commit-bot: I haz the power, 2016-12-17 02:28:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 04:35:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481941662373700,
"parent_rev": "d89328fb427834e600ac61d91809c70ff11ede29", "commit_rev":
"39b435c020a5f823203ef689c340b9b1c6259c32"}

[commit-bot: I haz the power, 2016-12-17 04:36:15]

Description was changed from

==========
[SPInvalidation] Update paint properties on perspective etc. change

BUG=645667
TEST=virtual/spinvalidation/paint/invalidation/perspective.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[SPInvalidation] Update paint properties on perspective etc. change

BUG=645667
TEST=virtual/spinvalidation/paint/invalidation/perspective.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2580713005
==========

[commit-bot: I haz the power, 2016-12-17 04:36:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-17 04:38:17]

Description was changed from

==========
[SPInvalidation] Update paint properties on perspective etc. change

BUG=645667
TEST=virtual/spinvalidation/paint/invalidation/perspective.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2580713005
==========

to

==========
[SPInvalidation] Update paint properties on perspective etc. change

BUG=645667
TEST=virtual/spinvalidation/paint/invalidation/perspective.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/3446d1745a09854682d54031e433429d68589fce
Cr-Commit-Position: refs/heads/master@{#439319}
==========

[commit-bot: I haz the power, 2016-12-17 04:38:18]

Patchset 2 (id:??) landed as
https://crrev.com/3446d1745a09854682d54031e433429d68589fce
Cr-Commit-Position: refs/heads/master@{#439319}