Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2580703002: CSS Animations layout tests: fix flaky animation-direction-normal.html (Closed)

Created:
4 years ago by Eric Willigers
Modified:
4 years ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS Animations layout tests: fix flaky animation-direction-normal.html We pause the animation, and progress using animationDelay. animation-direction-normal.html now uses testharness.js BUG=674123 Committed: https://crrev.com/cc8c722562636fdbb515c773ea3b2dcdaec4e813 Cr-Commit-Position: refs/heads/master@{#438764}

Patch Set 1 #

Total comments: 1

Patch Set 2 : no offsetTop #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -100 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/animations/animation-direction-normal.html View 1 1 chunk +28 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-direction-normal-expected.html View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Eric Willigers
We now follow the style in https://chromium.googlesource.com/chromium/src/+/master/docs/testing/writing_layout_tests.md
4 years ago (2016-12-15 04:10:37 UTC) #2
alancutter (OOO until 2018)
lgtm https://codereview.chromium.org/2580703002/diff/1/third_party/WebKit/LayoutTests/animations/animation-direction-normal.html File third_party/WebKit/LayoutTests/animations/animation-direction-normal.html (right): https://codereview.chromium.org/2580703002/diff/1/third_party/WebKit/LayoutTests/animations/animation-direction-normal.html#newcode30 third_party/WebKit/LayoutTests/animations/animation-direction-normal.html:30: target.offsetTop; This line is not necessary.
4 years ago (2016-12-15 04:20:17 UTC) #5
Eric Willigers
On 2016/12/15 04:20:17, alancutter wrote: > https://codereview.chromium.org/2580703002/diff/1/third_party/WebKit/LayoutTests/animations/animation-direction-normal.html#newcode30 > third_party/WebKit/LayoutTests/animations/animation-direction-normal.html:30: > target.offsetTop; > This line is ...
4 years ago (2016-12-15 04:27:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580703002/20001
4 years ago (2016-12-15 04:27:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/123342) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-15 04:29:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580703002/40001
4 years ago (2016-12-15 04:49:09 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-15 06:06:32 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-15 06:09:58 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cc8c722562636fdbb515c773ea3b2dcdaec4e813
Cr-Commit-Position: refs/heads/master@{#438764}

Powered by Google App Engine
This is Rietveld 408576698