Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 2580673002: [DevTools] Introduce typed events. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
lushnikov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Introduce typed events. These are now type-checked by compiler. BUG=none Committed: https://crrev.com/78b49dc97ebe44a435b12c946e7bfbf1870afab3 Cr-Commit-Position: refs/heads/master@{#439054}

Patch Set 1 #

Patch Set 2 : [DevTools] Introduce typed events. #

Patch Set 3 : [DevTools] Introduce typed events. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -23 lines) Patch
M third_party/WebKit/Source/devtools/front_end/common/Object.js View 4 chunks +97 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DatabaseModel.js View 1 2 2 chunks +11 lines, -6 lines 2 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js View 1 3 chunks +7 lines, -15 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (7 generated)
dgozman
Could you please take a look?
4 years ago (2016-12-15 03:10:19 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/2580673002/diff/40001/third_party/WebKit/Source/devtools/front_end/resources/DatabaseModel.js File third_party/WebKit/Source/devtools/front_end/resources/DatabaseModel.js (right): https://codereview.chromium.org/2580673002/diff/40001/third_party/WebKit/Source/devtools/front_end/resources/DatabaseModel.js#newcode189 third_party/WebKit/Source/devtools/front_end/resources/DatabaseModel.js:189: Resources.DatabaseModel.DatabaseAddedEvent = class { maybe we can keep ...
4 years ago (2016-12-15 04:29:00 UTC) #3
pfeldman
lgtm
4 years ago (2016-12-16 02:31:18 UTC) #4
dgozman
https://codereview.chromium.org/2580673002/diff/40001/third_party/WebKit/Source/devtools/front_end/resources/DatabaseModel.js File third_party/WebKit/Source/devtools/front_end/resources/DatabaseModel.js (right): https://codereview.chromium.org/2580673002/diff/40001/third_party/WebKit/Source/devtools/front_end/resources/DatabaseModel.js#newcode189 third_party/WebKit/Source/devtools/front_end/resources/DatabaseModel.js:189: Resources.DatabaseModel.DatabaseAddedEvent = class { On 2016/12/15 04:28:59, lushnikov wrote: ...
4 years ago (2016-12-16 04:17:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580673002/40001
4 years ago (2016-12-16 04:18:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/252890)
4 years ago (2016-12-16 04:49:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580673002/40001
4 years ago (2016-12-16 05:16:43 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-16 07:03:59 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-16 07:07:21 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/78b49dc97ebe44a435b12c946e7bfbf1870afab3
Cr-Commit-Position: refs/heads/master@{#439054}

Powered by Google App Engine
This is Rietveld 408576698