Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2580663003: Autoresize the sign-in email confirmation dialog. (Closed)

Created:
4 years ago by msarda
Modified:
4 years ago
Reviewers:
anthonyvd
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autoresize the sign-in email confirmation dialog. This CL uses an auto-resizeble WebUI constrained dialog to ensure that it is loaded with the right height. Screenshots: https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbTkVxc0twaDJhWjQ/view?usp=sharing https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbZmVFVXY1TnZmalU/view?usp=sharing BUG=670238 Committed: https://crrev.com/6333edb8c4a6fe199bba36b0f453c81c06e6e3e9 Cr-Commit-Position: refs/heads/master@{#438853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/ui/webui/signin/signin_email_confirmation_dialog.cc View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
msarda
Please take a look.
4 years ago (2016-12-15 16:09:34 UTC) #3
anthonyvd
lgtm. You might want to look into migrating the Signin Error and Sync Confirmation modals ...
4 years ago (2016-12-15 16:22:39 UTC) #4
msarda
On 2016/12/15 16:22:39, anthonyvd wrote: > lgtm. > > You might want to look into ...
4 years ago (2016-12-15 16:27:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580663003/1
4 years ago (2016-12-15 16:27:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 17:05:41 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-15 17:08:08 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6333edb8c4a6fe199bba36b0f453c81c06e6e3e9
Cr-Commit-Position: refs/heads/master@{#438853}

Powered by Google App Engine
This is Rietveld 408576698