Autoresize the sign-in email confirmation dialog.

Autoresize the sign-in email confirmation dialog.

This CL uses an auto-resizeble WebUI constrained dialog to ensure that
it is loaded with the right height.

Screenshots:
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbTkVxc0twaDJhWjQ/view?usp=sharing
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbZmVFVXY1TnZmalU/view?usp=sharing

BUG=670238
Committed: https://crrev.com/6333edb8c4a6fe199bba36b0f453c81c06e6e3e9
Cr-Commit-Position: refs/heads/master@{#438853}

[msarda, 2016-12-15 16:09:09]

Description was changed from

==========
Autoresize the sign-in email confirmation dialog.

This CL uses an auto-resizeble WebUI constrained dialog to ensure that
it is loaded with the right height.

BUG=670238
==========

to

==========
Autoresize the sign-in email confirmation dialog.

This CL uses an auto-resizeble WebUI constrained dialog to ensure that
it is loaded with the right height.

Screenshots:
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbTkVxc0twaDJhWjQ/v...
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbZmVFVXY1TnZmalU/v...

BUG=670238
==========

[msarda, 2016-12-15 16:09:34]

msarda@chromium.org changed reviewers:
+ anthonyvd@chromium.org

[msarda, 2016-12-15 16:09:34]

Please take a look.

[anthonyvd, 2016-12-15 16:22:39]

lgtm.

You might want to look into migrating the Signin Error and Sync Confirmation
modals as well, since they use a custom mechanism to do the resizing:
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/signin/signin_er....
I guess it's not necessary if you're moving to native soon though, just thought
I'd mention it :)

[msarda, 2016-12-15 16:27:08]

On 2016/12/15 16:22:39, anthonyvd wrote:
> lgtm.
> 
> You might want to look into migrating the Signin Error and Sync Confirmation
> modals as well, since they use a custom mechanism to do the resizing:
>
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/signin/signin_er....
> I guess it's not necessary if you're moving to native soon though, just
thought
> I'd mention it :)

I think that for now I'll kept them as they are as we do not have the man power
to tackle this refactoring.

[msarda, 2016-12-15 16:27:15]

The CQ bit was checked by msarda@chromium.org

[commit-bot: I haz the power, 2016-12-15 16:27:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 17:05:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481819235221740, "parent_rev":
"012a91a1ac9c96e932ae0948c0797db6e0d4c8cf", "commit_rev":
"8569949e29fdd54fd6452095068b39b4a9d9f989"}

[commit-bot: I haz the power, 2016-12-15 17:05:40]

Description was changed from

==========
Autoresize the sign-in email confirmation dialog.

This CL uses an auto-resizeble WebUI constrained dialog to ensure that
it is loaded with the right height.

Screenshots:
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbTkVxc0twaDJhWjQ/v...
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbZmVFVXY1TnZmalU/v...

BUG=670238
==========

to

==========
Autoresize the sign-in email confirmation dialog.

This CL uses an auto-resizeble WebUI constrained dialog to ensure that
it is loaded with the right height.

Screenshots:
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbTkVxc0twaDJhWjQ/v...
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbZmVFVXY1TnZmalU/v...

BUG=670238

Review-Url: https://codereview.chromium.org/2580663003
==========

[commit-bot: I haz the power, 2016-12-15 17:05:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-15 17:08:07]

Description was changed from

==========
Autoresize the sign-in email confirmation dialog.

This CL uses an auto-resizeble WebUI constrained dialog to ensure that
it is loaded with the right height.

Screenshots:
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbTkVxc0twaDJhWjQ/v...
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbZmVFVXY1TnZmalU/v...

BUG=670238

Review-Url: https://codereview.chromium.org/2580663003
==========

to

==========
Autoresize the sign-in email confirmation dialog.

This CL uses an auto-resizeble WebUI constrained dialog to ensure that
it is loaded with the right height.

Screenshots:
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbTkVxc0twaDJhWjQ/v...
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbZmVFVXY1TnZmalU/v...

BUG=670238

Committed: https://crrev.com/6333edb8c4a6fe199bba36b0f453c81c06e6e3e9
Cr-Commit-Position: refs/heads/master@{#438853}
==========

[commit-bot: I haz the power, 2016-12-15 17:08:08]

Patchset 1 (id:??) landed as
https://crrev.com/6333edb8c4a6fe199bba36b0f453c81c06e6e3e9
Cr-Commit-Position: refs/heads/master@{#438853}