[MD settings] remove selectedSite property

[MD settings] remove selectedSite property

This CL cleans up a selectedSite member and replaces it with a more
clear selectedSiteForUnitTest member.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/02d6371083153a096a550fb7f4acbc0bfc48b26e
Cr-Commit-Position: refs/heads/master@{#439039}

[dschuyler, 2016-12-15 23:05:52]

Description was changed from

==========
[MD settings] remove unused selectedSite property

This CL cleans up a selectedSite member and replaces it with a more
clear selectedSiteForUnitTest member.

BUG=None
==========

to

==========
[MD settings] remove unused selectedSite property

This CL cleans up a selectedSite member and replaces it with a more
clear selectedSiteForUnitTest member.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-12-15 23:05:54]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2016-12-15 23:06:25]

Description was changed from

==========
[MD settings] remove unused selectedSite property

This CL cleans up a selectedSite member and replaces it with a more
clear selectedSiteForUnitTest member.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] remove selectedSite property

This CL cleans up a selectedSite member and replaces it with a more
clear selectedSiteForUnitTest member.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-12-15 23:06:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-12-15 23:07:55]

dschuyler@chromium.org changed reviewers:
+ tommycli@chromium.org

[commit-bot: I haz the power, 2016-12-16 00:27:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 00:27:01]

Dry run: This issue passed the CQ dry run.

[tommycli, 2016-12-16 00:39:49]

LGTM except nit below.

Thanks for doing this!

https://codereview.chromium.org/2580653003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/site_list.js (right):

https://codereview.chromium.org/2580653003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/site_list.js:398:
this.selectedSiteForUnitTest = event.model.item;
I think you can also eliminate this by testing for the 'site' key in
URLSearchParams.

https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/route....

Also - I assume you double checked my conjecture that selectedSite is indeed not
needed?

[dschuyler, 2016-12-16 00:52:45]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 00:53:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-12-16 01:11:20]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2016-12-16 01:11:29]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-12-16 01:11:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-12-16 01:11:58]

https://codereview.chromium.org/2580653003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/site_list.js (right):

https://codereview.chromium.org/2580653003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/site_list.js:398:
this.selectedSiteForUnitTest = event.model.item;
On 2016/12/16 00:39:49, tommycli wrote:
> I think you can also eliminate this by testing for the 'site' key in
> URLSearchParams.
> 
>
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/route....
> 
> Also - I assume you double checked my conjecture that selectedSite is indeed
not
> needed?

Done.

[dschuyler, 2016-12-16 03:00:22]

The CQ bit was unchecked by dschuyler@chromium.org

[dschuyler, 2016-12-16 04:18:28]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-12-16 04:18:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2580653003/#ps40001
(title: "nits")

[commit-bot: I haz the power, 2016-12-16 04:19:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 05:48:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481861908653340,
"parent_rev": "0bf60094bbaa087dc8480b05be15eb3e23d72a3c", "commit_rev":
"51a3c2d99b7d10a4c64e6a597204f03a7306a0bc"}

[commit-bot: I haz the power, 2016-12-16 05:49:26]

Description was changed from

==========
[MD settings] remove selectedSite property

This CL cleans up a selectedSite member and replaces it with a more
clear selectedSiteForUnitTest member.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] remove selectedSite property

This CL cleans up a selectedSite member and replaces it with a more
clear selectedSiteForUnitTest member.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2580653003
==========

[commit-bot: I haz the power, 2016-12-16 05:49:31]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-12-16 05:51:50]

Description was changed from

==========
[MD settings] remove selectedSite property

This CL cleans up a selectedSite member and replaces it with a more
clear selectedSiteForUnitTest member.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2580653003
==========

to

==========
[MD settings] remove selectedSite property

This CL cleans up a selectedSite member and replaces it with a more
clear selectedSiteForUnitTest member.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/02d6371083153a096a550fb7f4acbc0bfc48b26e
Cr-Commit-Position: refs/heads/master@{#439039}
==========

[commit-bot: I haz the power, 2016-12-16 05:51:51]

Patchset 2 (id:??) landed as
https://crrev.com/02d6371083153a096a550fb7f4acbc0bfc48b26e
Cr-Commit-Position: refs/heads/master@{#439039}