Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 2580653002: [cleanup] Drop unused Allocate*String MacroAssembler instructions (Closed)

Created:
4 years ago by Jakob Kummerow
Modified:
4 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Drop unused Allocate*String MacroAssembler instructions Review-Url: https://codereview.chromium.org/2580653002 Cr-Commit-Position: refs/heads/master@{#41813} Committed: https://chromium.googlesource.com/v8/v8/+/9fcceeb176cf47cd773dd0a74ab84b2bb2f31fb3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1440 lines) Patch
M src/arm/macro-assembler-arm.h View 2 chunks +0 lines, -31 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +0 lines, -119 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 2 chunks +0 lines, -44 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 2 chunks +0 lines, -167 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 2 chunks +0 lines, -32 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +0 lines, -146 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 2 chunks +0 lines, -31 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +0 lines, -117 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 2 chunks +0 lines, -31 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 2 chunks +0 lines, -117 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 2 chunks +0 lines, -24 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 2 chunks +0 lines, -110 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 2 chunks +0 lines, -24 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 2 chunks +0 lines, -103 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -30 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +0 lines, -136 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 2 chunks +0 lines, -32 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 2 chunks +0 lines, -146 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Jakob Kummerow
PTAL. All users of these have moved to the CodeStubAssembler.
4 years ago (2016-12-16 23:08:45 UTC) #6
Yang
On 2016/12/16 23:08:45, Jakob Kummerow wrote: > PTAL. All users of these have moved to ...
4 years ago (2016-12-19 07:51:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580653002/1
4 years ago (2016-12-19 16:06:03 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-19 16:36:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9fcceeb176cf47cd773dd0a74ab84b2bb2f...

Powered by Google App Engine
This is Rietveld 408576698