Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2580633002: Adds tapted@ and msw@ to ui/views/OWNERS (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
Reviewers:
msw, tapted
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds tapted@ and msw@ to ui/views/OWNERS R=msw@chromium.org, tapted@chromium.org BUG=none TEST=none Committed: https://crrev.com/8522d9c97f63e212b6e2284a81220e30bc5bfa95 Cr-Commit-Position: refs/heads/master@{#438837}

Patch Set 1 #

Total comments: 2

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/views/OWNERS View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
sky
4 years ago (2016-12-15 00:29:23 UTC) #1
tapted
lgtm :) https://codereview.chromium.org/2580633002/diff/1/ui/views/OWNERS File ui/views/OWNERS (right): https://codereview.chromium.org/2580633002/diff/1/ui/views/OWNERS#newcode6 ui/views/OWNERS:6: per-file *_mac*=tapted@chromium.org I guess this is redundant ...
4 years ago (2016-12-15 00:39:38 UTC) #2
sky
https://codereview.chromium.org/2580633002/diff/1/ui/views/OWNERS File ui/views/OWNERS (right): https://codereview.chromium.org/2580633002/diff/1/ui/views/OWNERS#newcode6 ui/views/OWNERS:6: per-file *_mac*=tapted@chromium.org On 2016/12/15 00:39:38, tapted wrote: > I ...
4 years ago (2016-12-15 00:43:03 UTC) #3
msw
lgtm too :)
4 years ago (2016-12-15 00:45:15 UTC) #4
sky
On 2016/12/15 00:43:03, sky wrote: > https://codereview.chromium.org/2580633002/diff/1/ui/views/OWNERS > File ui/views/OWNERS (right): > > https://codereview.chromium.org/2580633002/diff/1/ui/views/OWNERS#newcode6 > ...
4 years ago (2016-12-15 15:56:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580633002/20001
4 years ago (2016-12-15 15:56:32 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-15 16:07:25 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-15 16:10:32 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8522d9c97f63e212b6e2284a81220e30bc5bfa95
Cr-Commit-Position: refs/heads/master@{#438837}

Powered by Google App Engine
This is Rietveld 408576698