Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 258063008: Revert "Rename experimental.accessibility to accessibilityPrivate" (Closed)

Created:
6 years, 7 months ago by David Tseng
Modified:
6 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Revert "Rename experimental.accessibility to accessibilityPrivate" This reverts commit 5d76e14014f504a496e111ecf23a433f1bbd5897. Original review: https://codereview.chromium.org/106973003 BUG=362442, 278540 TBR=dmazzoni TEST=Manually verify ChromeVox starts on guest mode. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266737

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -414 lines) Patch
M .gitmodules View 7 chunks +8 lines, -20 lines 0 comments Download
M chrome/browser/accessibility/accessibility_extension_api.h View 1 chunk +12 lines, -12 lines 0 comments Download
M chrome/browser/accessibility/accessibility_extension_api.cc View 13 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/accessibility/accessibility_extension_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/common/extensions/api/accessibility_private.json View 1 chunk +0 lines, -337 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 2 chunks +1 line, -1 line 0 comments Download
A + chrome/common/extensions/api/experimental_accessibility.json View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions_api_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/accessibility/get_alerts_for_tab/background.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/accessibility/get_alerts_for_tab/manifest.json View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/permissions/enabled/background.js View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/permissions/enabled/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/permissions/experimental_disabled/background.js View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/common/extension_api.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/common/permissions/api_permission.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
David Tseng
The CQ bit was checked by dtseng@chromium.org
6 years, 7 months ago (2014-04-28 21:47:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/258063008/1
6 years, 7 months ago (2014-04-28 21:49:19 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 21:53:35 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel tryserver.chromium on linux_chromium_gn_rel tryserver.chromium on linux_chromium_rel
6 years, 7 months ago (2014-04-28 21:53:35 UTC) #4
David Tseng
The CQ bit was checked by dtseng@chromium.org
6 years, 7 months ago (2014-04-28 22:31:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/258063008/20001
6 years, 7 months ago (2014-04-28 22:33:11 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:38:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg tryserver.chromium on linux_chromium_chromeos_rel tryserver.chromium on linux_chromium_gn_rel
6 years, 7 months ago (2014-04-28 22:38:45 UTC) #8
David Tseng
The CQ bit was checked by dtseng@chromium.org
6 years, 7 months ago (2014-04-29 01:56:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/258063008/20001
6 years, 7 months ago (2014-04-29 01:58:07 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 02:00:56 UTC) #11
Message was sent while issue was closed. 
Change committed as 266737

Powered by Google App Engine
This is Rietveld 408576698