Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Issue 2580583002: Moving hiding of paste menu from scroll start to scroll update (Closed)

Created:
4 years ago by amaralp
Modified:
4 years ago
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moving hiding of paste menu from scroll start to scroll update Previously we were hiding the paste menu even when the page didn't scroll at all. Moving the hiding to update ensures that the menu is only cleared if we actually scrolled. BUG=673209 Committed: https://crrev.com/99f54b1704faa5413d106b23a64a434368ea9628 Cr-Commit-Position: refs/heads/master@{#438708}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
amaralp
PTAL
4 years ago (2016-12-14 23:31:37 UTC) #4
aelias_OOO_until_Jul13
lgtm
4 years ago (2016-12-14 23:45:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580583002/1
4 years ago (2016-12-15 01:03:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 01:35:32 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-15 01:38:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99f54b1704faa5413d106b23a64a434368ea9628
Cr-Commit-Position: refs/heads/master@{#438708}

Powered by Google App Engine
This is Rietveld 408576698