Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2580543002:
Fixed a crash scrolls bug. (Closed)
|
Created:
4 years ago by Jia Modified:
4 years ago Reviewers:
Robert Sesek CC:
chromium-reviews, kalyank, sadrul, napper Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix a scroll-position issue on about:crashes.
Clicking on "Send Now" should not scroll to the top.
This cl patches in the solution devised by phistuck@gmail.com. See bug 659491 for detail.
BUG=659491
Committed: https://crrev.com/c849cb75f6f4f9a13e376006cbfb6da8c5d34faf
Cr-Commit-Position: refs/heads/master@{#439022}
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
The CQ bit was checked by jiameng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fixed a crash scrolls bug. BUG=659491 ========== to ========== Fixed a crash scrolls bug. This cl patches in the solution devised by phistuck@gmail.com. See bug 659491 for detail. BUG=659491 ==========
jiameng@chromium.org changed reviewers: + rsesek@chromium.org
Hi Robert, I've patched in a solution from phistuck@gmail.com, please review. Thanks, Jia
LGTM, but I'd re-word the description, since right now it sounds like this is fixing a bug about crashing when scrolling. Maybe: """ Fix a scroll-position issue on about:crashes. Clicking on "Send Now" should not scroll to the top. """
Description was changed from ========== Fixed a crash scrolls bug. This cl patches in the solution devised by phistuck@gmail.com. See bug 659491 for detail. BUG=659491 ========== to ========== Fix a scroll-position issue on about:crashes. Clicking on "Send Now" should not scroll to the top. This cl patches in the solution devised by phistuck@gmail.com. See bug 659491 for detail. BUG=659491 ==========
On 2016/12/15 20:32:41, Robert Sesek wrote: > LGTM, but I'd re-word the description, since right now it sounds like this is > fixing a bug about crashing when scrolling. > > Maybe: > > """ > Fix a scroll-position issue on about:crashes. > > Clicking on "Send Now" should not scroll to the top. > """ Thanks! Changed it. :) Jia
The CQ bit was checked by jiameng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481856026322350, "parent_rev":
"9c0cccf4b0557bd0b945023afb480857693ee1b3", "commit_rev":
"319598bd422fd2e79b8a89cc8501e2b27a59f8a8"}
Message was sent while issue was closed.
Description was changed from ========== Fix a scroll-position issue on about:crashes. Clicking on "Send Now" should not scroll to the top. This cl patches in the solution devised by phistuck@gmail.com. See bug 659491 for detail. BUG=659491 ========== to ========== Fix a scroll-position issue on about:crashes. Clicking on "Send Now" should not scroll to the top. This cl patches in the solution devised by phistuck@gmail.com. See bug 659491 for detail. BUG=659491 Review-Url: https://codereview.chromium.org/2580543002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix a scroll-position issue on about:crashes. Clicking on "Send Now" should not scroll to the top. This cl patches in the solution devised by phistuck@gmail.com. See bug 659491 for detail. BUG=659491 Review-Url: https://codereview.chromium.org/2580543002 ========== to ========== Fix a scroll-position issue on about:crashes. Clicking on "Send Now" should not scroll to the top. This cl patches in the solution devised by phistuck@gmail.com. See bug 659491 for detail. BUG=659491 Committed: https://crrev.com/c849cb75f6f4f9a13e376006cbfb6da8c5d34faf Cr-Commit-Position: refs/heads/master@{#439022} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c849cb75f6f4f9a13e376006cbfb6da8c5d34faf Cr-Commit-Position: refs/heads/master@{#439022} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
