Issue 258053008: Limit renderer saved frames to avoid running out of fds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 258053008: Limit renderer saved frames to avoid running out of fds. (Closed)

Created:
6 years, 7 months ago by jbauman

Modified:
6 years, 7 months ago

Reviewers:
danakj, piman

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Limit renderer saved frames to avoid running out of fds. Software delegated rendering uses one fd per tile, so with a bunch of tiles that means it can run out of fds. If it seems close to hitting the limit the browser should throw away old frames to avoid this from happening. BUG=362603 TBR=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266646

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -2 lines)			Patch
M	content/browser/renderer_host/render_widget_host_view_aura_unittest.cc	View	4 chunks	+32 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/renderer_frame_manager.h	View	2 chunks	+4 lines, -0 lines	1 comment	Download
M	content/browser/renderer_host/renderer_frame_manager.cc	View	2 chunks	+16 lines, -2 lines	0 comments	Download
M	content/common/host_shared_bitmap_manager.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jbauman

Committed patchset #1 manually as r266646 (presubmit successful).

6 years, 7 months ago (2014-04-28 20:27:12 UTC) #1

danakj

6 years, 7 months ago (2014-04-28 20:34:49 UTC) #2

Message was sent while issue was closed.

https://codereview.chromium.org/258053008/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/renderer_frame_manager.h (right):

https://codereview.chromium.org/258053008/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/renderer_frame_manager.h:37: void
set_max_handles(float max_handles) { max_handles_ = max_handles; }
Can use SetMaxHandlesForTests() to make the comment a compile-time check.

Expand Messages | Collapse Messages