Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 258053008: Limit renderer saved frames to avoid running out of fds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_view_aura.h" 5 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/memory/shared_memory.h" 8 #include "base/memory/shared_memory.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
11 #include "base/strings/utf_string_conversions.h" 11 #include "base/strings/utf_string_conversions.h"
12 #include "cc/output/compositor_frame.h" 12 #include "cc/output/compositor_frame.h"
13 #include "cc/output/compositor_frame_metadata.h" 13 #include "cc/output/compositor_frame_metadata.h"
14 #include "cc/output/copy_output_request.h" 14 #include "cc/output/copy_output_request.h"
15 #include "content/browser/browser_thread_impl.h" 15 #include "content/browser/browser_thread_impl.h"
16 #include "content/browser/compositor/resize_lock.h" 16 #include "content/browser/compositor/resize_lock.h"
17 #include "content/browser/renderer_host/render_widget_host_delegate.h" 17 #include "content/browser/renderer_host/render_widget_host_delegate.h"
18 #include "content/browser/renderer_host/render_widget_host_impl.h" 18 #include "content/browser/renderer_host/render_widget_host_impl.h"
19 #include "content/common/gpu/gpu_messages.h" 19 #include "content/common/gpu/gpu_messages.h"
20 #include "content/common/host_shared_bitmap_manager.h"
20 #include "content/common/input_messages.h" 21 #include "content/common/input_messages.h"
21 #include "content/common/view_messages.h" 22 #include "content/common/view_messages.h"
22 #include "content/port/browser/render_widget_host_view_frame_subscriber.h" 23 #include "content/port/browser/render_widget_host_view_frame_subscriber.h"
23 #include "content/public/browser/render_widget_host_view.h" 24 #include "content/public/browser/render_widget_host_view.h"
24 #include "content/public/test/mock_render_process_host.h" 25 #include "content/public/test/mock_render_process_host.h"
25 #include "content/public/test/test_browser_context.h" 26 #include "content/public/test/test_browser_context.h"
26 #include "ipc/ipc_test_sink.h" 27 #include "ipc/ipc_test_sink.h"
27 #include "testing/gmock/include/gmock/gmock.h" 28 #include "testing/gmock/include/gmock/gmock.h"
28 #include "testing/gtest/include/gtest/gtest.h" 29 #include "testing/gtest/include/gtest/gtest.h"
29 #include "ui/aura/client/aura_constants.h" 30 #include "ui/aura/client/aura_constants.h"
(...skipping 1034 matching lines...) Expand 10 before | Expand all | Expand 10 after
1064 view_->window_->RemoveObserver(&observer); 1065 view_->window_->RemoveObserver(&observer);
1065 } 1066 }
1066 1067
1067 TEST_F(RenderWidgetHostViewAuraTest, DiscardDelegatedFrames) { 1068 TEST_F(RenderWidgetHostViewAuraTest, DiscardDelegatedFrames) {
1068 size_t max_renderer_frames = 1069 size_t max_renderer_frames =
1069 RendererFrameManager::GetInstance()->max_number_of_saved_frames(); 1070 RendererFrameManager::GetInstance()->max_number_of_saved_frames();
1070 ASSERT_LE(2u, max_renderer_frames); 1071 ASSERT_LE(2u, max_renderer_frames);
1071 size_t renderer_count = max_renderer_frames + 1; 1072 size_t renderer_count = max_renderer_frames + 1;
1072 gfx::Rect view_rect(100, 100); 1073 gfx::Rect view_rect(100, 100);
1073 gfx::Size frame_size = view_rect.size(); 1074 gfx::Size frame_size = view_rect.size();
1075 DCHECK_EQ(0u, HostSharedBitmapManager::current()->AllocatedBitmapCount());
1074 1076
1075 scoped_ptr<RenderWidgetHostImpl * []> hosts( 1077 scoped_ptr<RenderWidgetHostImpl * []> hosts(
1076 new RenderWidgetHostImpl* [renderer_count]); 1078 new RenderWidgetHostImpl* [renderer_count]);
1077 scoped_ptr<FakeRenderWidgetHostViewAura * []> views( 1079 scoped_ptr<FakeRenderWidgetHostViewAura * []> views(
1078 new FakeRenderWidgetHostViewAura* [renderer_count]); 1080 new FakeRenderWidgetHostViewAura* [renderer_count]);
1079 1081
1080 // Create a bunch of renderers. 1082 // Create a bunch of renderers.
1081 for (size_t i = 0; i < renderer_count; ++i) { 1083 for (size_t i = 0; i < renderer_count; ++i) {
1082 hosts[i] = new RenderWidgetHostImpl( 1084 hosts[i] = new RenderWidgetHostImpl(
1083 &delegate_, process_host_, MSG_ROUTING_NONE, false); 1085 &delegate_, process_host_, MSG_ROUTING_NONE, false);
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
1150 views[0]->WasShown(); 1152 views[0]->WasShown();
1151 views[0]->OnSwapCompositorFrame( 1153 views[0]->OnSwapCompositorFrame(
1152 1, MakeDelegatedFrame(1.f, frame_size, view_rect)); 1154 1, MakeDelegatedFrame(1.f, frame_size, view_rect));
1153 for (size_t i = 0; i < renderer_count; ++i) 1155 for (size_t i = 0; i < renderer_count; ++i)
1154 EXPECT_TRUE(views[i]->frame_provider_); 1156 EXPECT_TRUE(views[i]->frame_provider_);
1155 1157
1156 // Make [0] hidden, it should evict its frame. 1158 // Make [0] hidden, it should evict its frame.
1157 views[0]->WasHidden(); 1159 views[0]->WasHidden();
1158 EXPECT_FALSE(views[0]->frame_provider_); 1160 EXPECT_FALSE(views[0]->frame_provider_);
1159 1161
1162 for (size_t i = 0; i < renderer_count - 1; ++i)
1163 views[i]->WasHidden();
1164
1165 // Allocate enough bitmaps so that two frames (proportionally) would be
1166 // enough hit the handle limit.
1167 int handles_per_frame = 5;
1168 RendererFrameManager::GetInstance()->set_max_handles(handles_per_frame * 2);
1169
1170 for (size_t i = 0; i < (renderer_count - 1) * handles_per_frame; i++) {
1171 HostSharedBitmapManager::current()->ChildAllocatedSharedBitmap(
1172 1,
1173 base::SharedMemory::NULLHandle(),
1174 base::GetCurrentProcessHandle(),
1175 cc::SharedBitmap::GenerateId());
1176 }
1177
1178 // Hiding this last bitmap should evict all but two frames.
1179 views[renderer_count - 1]->WasHidden();
1180 for (size_t i = 0; i < renderer_count; ++i) {
1181 if (i + 2 < renderer_count)
1182 EXPECT_FALSE(views[i]->frame_provider_);
1183 else
1184 EXPECT_TRUE(views[i]->frame_provider_);
1185 }
1186 HostSharedBitmapManager::current()->ProcessRemoved(
1187 base::GetCurrentProcessHandle());
1188 RendererFrameManager::GetInstance()->set_max_handles(
1189 base::SharedMemory::GetHandleLimit());
1190
1160 for (size_t i = 0; i < renderer_count; ++i) { 1191 for (size_t i = 0; i < renderer_count; ++i) {
1161 views[i]->Destroy(); 1192 views[i]->Destroy();
1162 delete hosts[i]; 1193 delete hosts[i];
1163 } 1194 }
1164 } 1195 }
1165 1196
1166 TEST_F(RenderWidgetHostViewAuraTest, DiscardDelegatedFramesWithLocking) { 1197 TEST_F(RenderWidgetHostViewAuraTest, DiscardDelegatedFramesWithLocking) {
1167 size_t max_renderer_frames = 1198 size_t max_renderer_frames =
1168 RendererFrameManager::GetInstance()->max_number_of_saved_frames(); 1199 RendererFrameManager::GetInstance()->max_number_of_saved_frames();
1169 ASSERT_LE(2u, max_renderer_frames); 1200 ASSERT_LE(2u, max_renderer_frames);
1170 size_t renderer_count = max_renderer_frames + 1; 1201 size_t renderer_count = max_renderer_frames + 1;
1171 gfx::Rect view_rect(100, 100); 1202 gfx::Rect view_rect(100, 100);
1172 gfx::Size frame_size = view_rect.size(); 1203 gfx::Size frame_size = view_rect.size();
1204 DCHECK_EQ(0u, HostSharedBitmapManager::current()->AllocatedBitmapCount());
1173 1205
1174 scoped_ptr<RenderWidgetHostImpl * []> hosts( 1206 scoped_ptr<RenderWidgetHostImpl * []> hosts(
1175 new RenderWidgetHostImpl* [renderer_count]); 1207 new RenderWidgetHostImpl* [renderer_count]);
1176 scoped_ptr<FakeRenderWidgetHostViewAura * []> views( 1208 scoped_ptr<FakeRenderWidgetHostViewAura * []> views(
1177 new FakeRenderWidgetHostViewAura* [renderer_count]); 1209 new FakeRenderWidgetHostViewAura* [renderer_count]);
1178 1210
1179 // Create a bunch of renderers. 1211 // Create a bunch of renderers.
1180 for (size_t i = 0; i < renderer_count; ++i) { 1212 for (size_t i = 0; i < renderer_count; ++i) {
1181 hosts[i] = new RenderWidgetHostImpl( 1213 hosts[i] = new RenderWidgetHostImpl(
1182 &delegate_, process_host_, MSG_ROUTING_NONE, false); 1214 &delegate_, process_host_, MSG_ROUTING_NONE, false);
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
1344 1376
1345 // Because the copy request callback may be holding state within it, that 1377 // Because the copy request callback may be holding state within it, that
1346 // state must handle the RWHVA and ImageTransportFactory going away before the 1378 // state must handle the RWHVA and ImageTransportFactory going away before the
1347 // callback is called. This test passes if it does not crash as a result of 1379 // callback is called. This test passes if it does not crash as a result of
1348 // these things being destroyed. 1380 // these things being destroyed.
1349 EXPECT_EQ(2, callback_count_); 1381 EXPECT_EQ(2, callback_count_);
1350 EXPECT_FALSE(result_); 1382 EXPECT_FALSE(result_);
1351 } 1383 }
1352 1384
1353 } // namespace content 1385 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698