Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2580523002: Reland "Android: Switch to thread pool executor" (Closed)

Created:
4 years ago by Peter Wen
Modified:
4 years ago
Reviewers:
iclelland
CC:
chromium-reviews, iclelland+watch_chromium.org, Peter Beverloo, chasej+watch_chromium.org, jkarlin+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Android: Switch to thread pool executor" Original CL: http://crrev.com/2562643004 Fixes BackgroundSyncLauncherTest#testNewLauncherDisablesNextOnline. TBR=mariakhomenko@chromium.org BUG=601053, 674293 Committed: https://crrev.com/80528b6a6acce7e1cc5829aaae876fb608aabb18 Cr-Commit-Position: refs/heads/master@{#439511}

Patch Set 1 #

Patch Set 2 : Fix creation task. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -24 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncher.java View 10 chunks +24 lines, -18 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/BackgroundSyncLauncherTest.java View 1 6 chunks +21 lines, -4 lines 0 comments Download
M chrome/browser/android/background_sync_launcher_android.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Peter Wen
Hi Ian, Can you take a look at this fix? Just adding a wait function ...
4 years ago (2016-12-15 21:58:51 UTC) #4
Peter Wen
Friendly ping.
4 years ago (2016-12-19 17:58:07 UTC) #9
iclelland
On 2016/12/19 17:58:07, Peter Wen wrote: > Friendly ping. LGTM, sorry for the wait.
4 years ago (2016-12-19 18:26:54 UTC) #10
Peter Wen
On 2016/12/19 18:26:54, iclelland wrote: > On 2016/12/19 17:58:07, Peter Wen wrote: > > Friendly ...
4 years ago (2016-12-19 18:41:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580523002/20001
4 years ago (2016-12-19 18:42:19 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-19 18:49:39 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-19 18:52:16 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/80528b6a6acce7e1cc5829aaae876fb608aabb18
Cr-Commit-Position: refs/heads/master@{#439511}

Powered by Google App Engine
This is Rietveld 408576698