Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2580513002: [DevTools] Consume ToolbarButton click. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Consume ToolbarButton click. BUG=673678 Committed: https://crrev.com/84b0a5bee0609df9a5ff6e5c73569ccb265b3fbd Cr-Commit-Position: refs/heads/master@{#438702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dgozman
Take a look please.
4 years ago (2016-12-14 22:10:17 UTC) #3
lushnikov
lgtm
4 years ago (2016-12-15 01:08:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580513002/1
4 years ago (2016-12-15 01:08:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 01:23:25 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-15 01:26:41 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/84b0a5bee0609df9a5ff6e5c73569ccb265b3fbd
Cr-Commit-Position: refs/heads/master@{#438702}

Powered by Google App Engine
This is Rietveld 408576698