Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 2580503002: Revert of Android: Switch to thread pool executor (Closed)

Created:
4 years ago by Peter Wen
Modified:
4 years ago
Reviewers:
iclelland, Maria
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android: Switch to thread pool executor (patchset #7 id:120001 of https://codereview.chromium.org/2562643004/ ) Reason for revert: BackgroundSyncLauncherTest#testNewLauncherDisablesNextOnline fails. Original issue's description: > Android: Switch to thread pool executor. > > Switches BackgroundSyncLauncher to the thread pool executor and add > comments explaining why AsyncTask is necessary. > > BUG=601053 > > Committed: https://crrev.com/ad3ee42510afda09e00cb73c694bfa4626980d1d > Cr-Commit-Position: refs/heads/master@{#438573} TBR=iclelland@chromium.org,mariakhomenko@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=601053 Committed: https://crrev.com/0be43188cb2345a40a73205bb65dd4164aa9d259 Cr-Commit-Position: refs/heads/master@{#438645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -44 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncher.java View 10 chunks +19 lines, -25 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/BackgroundSyncLauncherTest.java View 5 chunks +4 lines, -18 lines 0 comments Download
M chrome/browser/android/background_sync_launcher_android.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Peter Wen
Created Revert of Android: Switch to thread pool executor
4 years ago (2016-12-14 22:00:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580503002/1
4 years ago (2016-12-14 22:00:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 22:02:05 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-14 22:04:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0be43188cb2345a40a73205bb65dd4164aa9d259
Cr-Commit-Position: refs/heads/master@{#438645}

Powered by Google App Engine
This is Rietveld 408576698