Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2580413002: Merged: [stubs] Fix negative index lookup in hasOwnProperty (Closed)

Created:
4 years ago by Jakob Kummerow
Modified:
4 years ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.6
Project:
v8
Visibility:
Public.

Description

Merged: [stubs] Fix negative index lookup in hasOwnProperty Revision: bb753b6dd72e0d132456983248c8f695a692f25d BUG=chromium:673008 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=ishell@chromium.org Review-Url: https://codereview.chromium.org/2580413002 . Cr-Commit-Position: refs/branch-heads/5.6@{#58} Cr-Branched-From: bdd3886218dfe76e8560eb8a18401942452ae859-refs/heads/5.6.326@{#1} Cr-Branched-From: 879f6599eee6e1dfcbe9a24bf688b261c03e9558-refs/heads/master@{#41014} Committed: https://chromium.googlesource.com/v8/v8/+/6ce1e0a02544eb3080dd0a6511cda55ae0df8f92

Patch Set 1 #

Patch Set 2 : fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M src/builtins/builtins-object.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-673008.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jakob Kummerow
4 years ago (2016-12-19 17:05:35 UTC) #1
Jakob Kummerow
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years ago (2016-12-19 17:05:36 UTC) #2
Igor Sheludko
lgtm
4 years ago (2016-12-19 17:08:39 UTC) #3
Jakob Kummerow
4 years ago (2016-12-19 17:09:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6ce1e0a02544eb3080dd0a6511cda55ae0df8f92.

Powered by Google App Engine
This is Rietveld 408576698