Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 2580373002: Revert of Generate Signed Distance Field directly from vector path (Closed)

Created:
4 years ago by rmistry
Modified:
4 years ago
CC:
reviews_skia.org, developer_arm.com
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Generate Signed Distance Field directly from vector path (patchset #23 id:440001 of https://codereview.chromium.org/1643143002/ ) Reason for revert: Seems to have caused lot of test bots to fail. Eg: https://luci-milo.appspot.com/swarming/task/332e3b427135f010 Original issue's description: > Generate Signed Distance Field directly from vector path > > Add SkGenerateDistanceFieldFromPath API to generate signed distance field directly from SkPath. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1643143002 > > Committed: https://skia.googlesource.com/skia/+/4de97a64e8829323a7070b623411d9f9ddb0cd0f > Committed: https://skia.googlesource.com/skia/+/e8f0a7b986f1e5583c9bc162efcdd92fd6430549 > Committed: https://skia.googlesource.com/skia/+/67c7c81a82b6351e9fbbf235084d7120162d9268 > Review-Url: https://codereview.chromium.org/1643143002 > Committed: https://skia.googlesource.com/skia/+/64b70b096ac20833d9737758a4bd5f2a51078bc4 TBR=bsalomon@google.com,jvanverth@google.com,mtklein@google.com,wasim.abbas@arm.com,caryclark@google.com,reed@google.com,egdaniel@google.com,joel.liang@arm.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2580373002 Committed: https://skia.googlesource.com/skia/+/a8b1e6d0688c7bc8754b0f49578144c77f5a180e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -978 lines) Patch
M gn/gpu.gni View 1 chunk +0 lines, -2 lines 0 comments Download
D src/gpu/GrDistanceFieldGenFromVector.h View 1 chunk +0 lines, -35 lines 0 comments Download
D src/gpu/GrDistanceFieldGenFromVector.cpp View 1 chunk +0 lines, -849 lines 0 comments Download
M src/gpu/ops/GrAADistanceFieldPathRenderer.cpp View 3 chunks +34 lines, -48 lines 0 comments Download
M src/gpu/text/GrAtlasGlyphCache.cpp View 2 chunks +21 lines, -44 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmistry
Created Revert of Generate Signed Distance Field directly from vector path
4 years ago (2016-12-19 12:32:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580373002/1
4 years ago (2016-12-19 12:32:23 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-19 12:32:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a8b1e6d0688c7bc8754b0f49578144c77f5a180e

Powered by Google App Engine
This is Rietveld 408576698