Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2580333003: Upstream Chrome on iOS source code [10/11]. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, aboxhall+watch_chromium.org, pkl (ping after 24h if needed), nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream Chrome on iOS source code [10/11]. Upstream part of Chrome on iOS source code. Nothing is built yet, just new files added. The files will be added to the build as part of the last CL to avoid breaking downstream tree. BUG=653086 Committed: https://crrev.com/a8a527c6cce513d634afb54f9068c237fd41f0da Cr-Commit-Position: refs/heads/master@{#439475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12722 lines, -0 lines) Patch
A ios/chrome/browser/ui/util/manual_text_framer.h View 1 chunk +36 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/manual_text_framer.mm View 1 chunk +636 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/manual_text_framer_unittest.mm View 1 chunk +301 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/relaxed_bounds_constraints_hittest.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/snapshot_util.h View 1 chunk +17 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/snapshot_util.mm View 1 chunk +25 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/text_frame.h View 1 chunk +63 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/text_frame.mm View 1 chunk +146 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/text_region_mapper.h View 1 chunk +46 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/text_region_mapper.mm View 1 chunk +107 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/text_region_mapper_unittest.mm View 1 chunk +144 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/top_view_controller.h View 1 chunk +19 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/top_view_controller.mm View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/transparent_link_button.h View 1 chunk +45 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/transparent_link_button.mm View 1 chunk +192 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/unicode_util.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/util/unicode_util.mm View 1 chunk +112 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/web_contents/README.md View 1 chunk +6 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/web_contents/web_contents_view_controller.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/web_contents/web_contents_view_controller.mm View 1 chunk +56 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/web_contents/web_coordinator.h View 1 chunk +34 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/web_contents/web_coordinator.mm View 1 chunk +45 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.h View 1 chunk +61 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.mm View 1 chunk +196 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/webui/omaha_ui.h View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/webui/omaha_ui.cc View 1 chunk +92 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/webui/signin_internals_ui_ios.h View 1 chunk +35 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/webui/signin_internals_ui_ios.cc View 1 chunk +106 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/webui/web_ui_egtest.mm View 1 chunk +226 lines, -0 lines 0 comments Download
A ios/chrome/browser/url_opening.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/README.md View 1 chunk +11 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/auto_reload_bridge.h View 1 chunk +36 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/auto_reload_bridge.mm View 1 chunk +86 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/auto_reload_controller.h View 1 chunk +49 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/auto_reload_controller.mm View 1 chunk +137 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/auto_reload_controller_unittest.mm View 1 chunk +184 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/blocked_popup_handler.h View 1 chunk +68 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/blocked_popup_handler.mm View 1 chunk +139 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/browsing_egtest.mm View 1 chunk +651 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/browsing_prevent_default_egtest.mm View 1 chunk +174 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/cache_egtest.mm View 1 chunk +288 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/child_window_open_by_dom_egtest.mm View 1 chunk +210 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/chrome_web_client.h View 1 chunk +55 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/chrome_web_client.mm View 1 chunk +189 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/chrome_web_client_unittest.mm View 1 chunk +87 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/chrome_web_test.h View 1 chunk +31 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/chrome_web_test.mm View 1 chunk +38 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/early_page_script_perftest.mm View 1 chunk +60 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/error_page_content.h View 1 chunk +36 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/error_page_content.mm View 1 chunk +91 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/error_page_content_unittest.mm View 1 chunk +116 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/external_app_launcher.h View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/external_app_launcher.mm View 1 chunk +182 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/external_app_launcher_disabler.h View 1 chunk +16 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/external_app_launcher_disabler.mm View 1 chunk +17 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/external_app_launcher_unittest.mm View 1 chunk +52 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/find_in_page_js_unittest.mm View 1 chunk +219 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/forms_egtest.mm View 1 chunk +289 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/js_findinpage_manager_unittest.mm View 1 chunk +79 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/js_print_egtest.mm View 1 chunk +56 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/navigation_egtest.mm View 1 chunk +692 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/passkit_dialog_provider.h View 1 chunk +16 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/print_observer.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/print_observer.mm View 1 chunk +49 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/progress_indicator_egtest.mm View 1 chunk +261 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/push_and_replace_state_navigation_egtest.mm View 1 chunk +354 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/stop_loading_egtest.mm View 1 chunk +139 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/visible_url_egtest.mm View 1 chunk +598 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/web_mediator.h View 1 chunk +36 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/web_mediator.mm View 1 chunk +33 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/web_mediator+internal.h View 1 chunk +26 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/window_open_by_dom_egtest.mm View 1 chunk +172 lines, -0 lines 0 comments Download
A ios/chrome/test/app/bookmarks_test_util.h View 1 chunk +18 lines, -0 lines 0 comments Download
A ios/chrome/test/app/bookmarks_test_util.mm View 1 chunk +28 lines, -0 lines 0 comments Download
A ios/chrome/test/app/chrome_test_util.h View 1 chunk +91 lines, -0 lines 0 comments Download
A ios/chrome/test/app/chrome_test_util.mm View 1 chunk +210 lines, -0 lines 0 comments Download
A ios/chrome/test/app/histogram_test_util.h View 1 chunk +122 lines, -0 lines 0 comments Download
A ios/chrome/test/app/histogram_test_util.mm View 1 chunk +187 lines, -0 lines 0 comments Download
A ios/chrome/test/app/history_test_util.h View 1 chunk +17 lines, -0 lines 0 comments Download
A ios/chrome/test/app/history_test_util.mm View 1 chunk +49 lines, -0 lines 0 comments Download
A ios/chrome/test/app/navigation_test_util.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/chrome/test/app/navigation_test_util.mm View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/chrome/test/app/settings_test_util.h View 1 chunk +17 lines, -0 lines 0 comments Download
A ios/chrome/test/app/settings_test_util.mm View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/chrome/test/app/signin_test_util.h View 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/test/app/signin_test_util.mm View 1 chunk +170 lines, -0 lines 0 comments Download
A ios/chrome/test/app/stack_view_test_util.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/test/app/stack_view_test_util.mm View 1 chunk +29 lines, -0 lines 0 comments Download
A ios/chrome/test/app/sync_test_util.h View 1 chunk +98 lines, -0 lines 0 comments Download
A ios/chrome/test/app/sync_test_util.mm View 1 chunk +351 lines, -0 lines 0 comments Download
A ios/chrome/test/app/tab_test_util.h View 1 chunk +83 lines, -0 lines 0 comments Download
A ios/chrome/test/app/tab_test_util.mm View 1 chunk +193 lines, -0 lines 0 comments Download
A ios/chrome/test/app/web_view_interaction_test_util.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/chrome/test/app/web_view_interaction_test_util.mm View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/chrome/test/base/perf_test_ios.h View 1 chunk +78 lines, -0 lines 0 comments Download
A ios/chrome/test/base/perf_test_ios.mm View 1 chunk +112 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/Info.plist View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/accessibility_util.h View 1 chunk +16 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/accessibility_util.mm View 1 chunk +353 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/chrome_actions.h View 1 chunk +29 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/chrome_actions.mm View 1 chunk +44 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/chrome_assertions.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/chrome_assertions.mm View 1 chunk +40 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/chrome_earl_grey.h View 1 chunk +49 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/chrome_earl_grey.mm View 1 chunk +96 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/chrome_earl_grey_ui.h View 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm View 1 chunk +62 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/chrome_matchers.h View 1 chunk +80 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/chrome_matchers.mm View 1 chunk +218 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/chrome_test_case.h View 1 chunk +36 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/chrome_test_case.mm View 1 chunk +297 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/chrome_util.h View 1 chunk +18 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/chrome_util.mm View 1 chunk +52 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/device_check_egtest.mm View 1 chunk +27 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/eg_tests_hook.mm View 1 chunk +33 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/shell_test.mm View 1 chunk +12 lines, -0 lines 0 comments Download
A ios/chrome/test/earl_grey/smoke_egtest.mm View 1 chunk +46 lines, -0 lines 0 comments Download
A ios/chrome/test/ocmock/OCMockObject+BreakpadControllerTesting.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/test/ocmock/OCMockObject+BreakpadControllerTesting.mm View 1 chunk +28 lines, -0 lines 0 comments Download
A ios/chrome/test/ocmock/OCMockObject+CrOCMockAdditions.h View 1 chunk +18 lines, -0 lines 0 comments Download
A ios/chrome/test/ocmock/OCMockObject+CrOCMockAdditions.mm View 1 chunk +39 lines, -0 lines 0 comments Download
A ios/chrome/test/ocmock/scoped_mock_object.h View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/chrome/test/ocmock/scoped_verifying_mock_object.h View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years ago (2016-12-19 14:49:37 UTC) #4
rohitrao (ping after 24h)
lgtm SHIP IT!
4 years ago (2016-12-19 14:55:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580333003/1
4 years ago (2016-12-19 14:55:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 15:04:36 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-19 15:06:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8a527c6cce513d634afb54f9068c237fd41f0da
Cr-Commit-Position: refs/heads/master@{#439475}

Powered by Google App Engine
This is Rietveld 408576698