[debug-wrapper] remove last uses of --expose-debug-as

[debug-wrapper] remove last uses of --expose-debug-as

The inspector cannot deal with breaking inside of debug-evaluate.
There is therefore no point in supporting that in the debugger.
The optional additional context parameter for debug-evaluate also
can be removed since it's not being used.

R=jgruber@chromium.org
BUG=v8:5530
Review-Url: https://codereview.chromium.org/2580323002
Cr-Commit-Position: refs/heads/master@{#41791}
Committed: https://chromium.googlesource.com/v8/v8/+/1296dd1f5a87d4286f455f6afc06dff403496278

[jgruber, 2016-12-19 09:46:33]

Nice, lgtm & nit

https://codereview.chromium.org/2580323002/diff/1/test/debugger/regress/regre...
File test/debugger/regress/regress-1639-2.js (right):

https://codereview.chromium.org/2580323002/diff/1/test/debugger/regress/regre...
test/debugger/regress/regress-1639-2.js:54:
exec_state.prepareStep(Debug.StepAction.StepNext);
If I understand correctly, this case isn't hit anymore?

[Yang, 2016-12-19 10:04:11]

https://codereview.chromium.org/2580323002/diff/1/test/debugger/regress/regre...
File test/debugger/regress/regress-1639-2.js (right):

https://codereview.chromium.org/2580323002/diff/1/test/debugger/regress/regre...
test/debugger/regress/regress-1639-2.js:54:
exec_state.prepareStep(Debug.StepAction.StepNext);
On 2016/12/19 09:46:33, jgruber wrote:
> If I understand correctly, this case isn't hit anymore?

Correct. Replaced with assertUnreachable.

[Yang, 2016-12-19 10:04:15]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-12-19 10:04:15]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2580323002/#ps20001
(title: "address comment")

[Yang, 2016-12-19 10:04:16]

The CQ bit was unchecked by yangguo@chromium.org

[Yang, 2016-12-19 10:04:17]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 10:04:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-12-19 10:04:46]

The CQ bit was unchecked by yangguo@chromium.org

[Yang, 2016-12-19 10:42:51]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-12-19 10:42:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 10:44:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482144171642370,
"parent_rev": "b29d6d4968ffc2ef602df1977c65c6b7fd8f1975", "commit_rev":
"1296dd1f5a87d4286f455f6afc06dff403496278"}

[commit-bot: I haz the power, 2016-12-19 10:44:43]

Description was changed from

==========
[debug-wrapper] remove last uses of --expose-debug-as

The inspector cannot deal with breaking inside of debug-evaluate.
There is therefore no point in supporting that in the debugger.
The optional additional context parameter for debug-evaluate also
can be removed since it's not being used.

R=jgruber@chromium.org
BUG=v8:5530
==========

to

==========
[debug-wrapper] remove last uses of --expose-debug-as

The inspector cannot deal with breaking inside of debug-evaluate.
There is therefore no point in supporting that in the debugger.
The optional additional context parameter for debug-evaluate also
can be removed since it's not being used.

R=jgruber@chromium.org
BUG=v8:5530

Review-Url: https://codereview.chromium.org/2580323002
Cr-Commit-Position: refs/heads/master@{#41791}
Committed:
https://chromium.googlesource.com/v8/v8/+/1296dd1f5a87d4286f455f6afc06dff4034...
==========

[commit-bot: I haz the power, 2016-12-19 10:44:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/1296dd1f5a87d4286f455f6afc06dff4034...