Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2580173002: DevTools: fix http/tests/inspector/search/sources-search-scope-many-projects.html (Closed)

Created:
4 years ago by lushnikov
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix http/tests/inspector/search/sources-search-scope-many-projects.html For some reason, this test was the only search test which didn't sort results. This patch starts sorting search results in the test. It also turns out that "sortByURI" flag is never used any more, so the CL removes it. BUG=674917 R=dgozman Committed: https://crrev.com/a423ff04ef3ae06ddf6b315b39dad05cb6a21d7a Cr-Commit-Position: refs/heads/master@{#439323}

Patch Set 1 #

Messages

Total messages: 14 (9 generated)
lushnikov
please, take a look
4 years ago (2016-12-17 00:59:12 UTC) #3
dgozman
lgtm
4 years ago (2016-12-17 01:08:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580173002/1
4 years ago (2016-12-17 04:40:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-17 04:44:50 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-17 04:48:19 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a423ff04ef3ae06ddf6b315b39dad05cb6a21d7a
Cr-Commit-Position: refs/heads/master@{#439323}

Powered by Google App Engine
This is Rietveld 408576698