Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2580153002: Revert of Use more accurate sRGB, Adobe, matrices (Closed)

Created:
4 years ago by rjkroege
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use more accurate sRGB, Adobe, matrices (patchset #1 id:1 of https://codereview.chromium.org/2583543003/ ) Reason for revert: Best guess at fixing many colour related layout test failures (mostly image but also text) after this CL landed. Test failures (across multiple WebKit bots): virtual/gpu-rasterization/images/embed-image.html css2.1/20110323/inline-replaced-height-002.htm ietestcenter/css3/bordersbackgrounds/background-color-border-box.htm css3/filters/effect-invert-hw.html virtual/gpu-rasterization/images/color-profile-image-profile-match.html virtual/display_list_2d_canvas/fast/canvas/canvas-toBlob-jpeg-medium-quality.html css3/blending/background-blend-mode-tiled-gradient.html css2.1/20110323/absolute-replaced-height-017.htm virtual/layout_ng/css2.1/20110323/inline-replaced-width-006.htm css2.1/20110323/absolute-replaced-height-022.htm css2.1/20110323/float-replaced-width-006.htm virtual/spinvalidation/paint/invalidation/compositing/page-scale-repaint.html virtual/gpu-rasterization/images/paletted-png-with-color-profile.html css3/blending/mix-blend-mode-isolated-group-1.html images/paletted-png-with-color-profile.html virtual/layout_ng/css2.1/20110323/block-replaced-height-001.htm fast/reflections/reflection-masks-opacity.html css3/blending/background-blend-mode-single-layer-no-blending.html css2.1/20110323/inline-block-replaced-height-001.htm css2.1/20110323/absolute-replaced-width-069.htm css3/blending/background-blend-mode-multiple-background-layers.html css2.1/20110323/absolute-replaced-height-023.htm css3/filters/effect-invert.html css2.1/20110323/block-replaced-height-003.htm css3/filters/effect-contrast.html css3/filters/effect-brightness.html images/color-profile-border-image-source.html css2.1/20110323/absolute-replaced-height-029.htm mhtml/invalid-bad-boundary2.mht css3/filters/effect-brightness-clamping-hw.html virtual/layout_ng/css2.1/20110323/inline-block-replaced-width-006.htm virtual/layout_ng/css2.1/20110323/inline-block-replaced-width-001.htm css2.1/20110323/absolute-replaced-height-031.htm css2.1/20110323/float-replaced-width-005.htm virtual/spinvalidation/paint/invalidation/background-image-paint-invalidation-small-document.html css2.1/20110323/float-replaced-height-001.htm css2.1/20110323/float-replaced-height-002.htm fast/canvas/canvas-toDataURL-webp.html css3/blending/effect-background-blend-mode.html css2.1/20110323/inline-replaced-height-003.htm virtual/layout_ng/css2.1/20110323/inline-block-replaced-height-001.htm css2.1/20110323/absolute-replaced-width-041.htm ietestcenter/css3/bordersbackgrounds/background_color_padding_box.htm fast/reflections/reflection-masks.html css2.1/20110323/block-replaced-height-002.htm virtual/gpu-rasterization/images/color-profile-border-image-source.html virtual/gpu/fast/canvas/canvas-toBlob-jpeg-medium-quality.html css3/filters/effect-blur-hw.html css3/filters/effect-combined.html css2.1/20110323/absolute-replaced-width-050.htm css3/filters/effect-brightness-clamping.html ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box.htm ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm fast/canvas/canvas-toBlob-jpeg-maximum-quality.html svg/as-border-image/svg-as-border-image-2.html css3/blending/background-blend-mode-image-image.html css2.1/20110323/absolute-replaced-width-029.htm css3/blending/background-blend-mode-separate-layer-declaration.html css2.1/20110323/float-replaced-width-001.htm css2.1/20110323/absolute-replaced-height-008.htm css2.1/20110323/float-replaced-width-004.htm fast/reflections/reflection-with-zoom.html css2.1/20110323/absolute-replaced-width-076.htm svg/W3C-SVG-1.1/struct-image-04-t.svg css2.1/20110323/float-replaced-width-003.htm css3/filters/effect-drop-shadow.html css2.1/20110323/absolute-replaced-height-009.htm css3/blending/mix-blend-mode-isolated-group-2.html css3/filters/effect-hue-rotate-hw.html css3/blending/background-blend-mode-opaque-layer.html virtual/spinvalidation/paint/invalidation/background-image-paint-invalidation-large-abspos-div.html css2.1/20110323/absolute-replaced-height-003.htm css2.1/20110323/inline-block-replaced-height-002.htm css2.1/20110323/absolute-replaced-width-022.htm css3/filters/effect-grayscale-hw.html css2.1/20110323/absolute-replaced-width-062.htm css3/blending/effect-background-blend-mode-stacking.html virtual/display_list_2d_canvas/fast/canvas/canvas-toBlob-webp-maximum-quality.html css2.1/20110323/absolute-replaced-width-055.htm virtual/display_list_2d_canvas/fast/canvas/canvas-toBlob-jpeg-maximum-quality.html fast/canvas/canvas-toBlob-webp-maximum-quality.html css2.1/20110323/absolute-replaced-width-043.htm fast/borders/border-image-omit-right-slice.html ietestcenter/css3/bordersbackgrounds/none-as-image-layer.htm virtual/display_list_2d_canvas/fast/canvas/canvas-toDataURL-jpeg-maximum-quality.html css3/filters/effect-contrast-hw.html css3/filters/effect-saturate-hw.html css3/filters/composited-reflected.html compositing/reflections/simple-composited-reflections.html virtual/gpu/fast/canvas/canvas-toDataURL-webp.html images/embed-image.html virtual/gpu/fast/canvas/canvas-toBlob-jpeg-maximum-quality.html images/object-image.html css2.1/20110323/absolute-replaced-width-048.htm css3/blending/background-blend-mode-image-svg.html css2.1/20110323/absolute-replaced-width-008.htm images/paint-subrect.html tables/mozilla/bugs/bug82946-2.html css2.1/20110323/inline-block-replaced-width-006.htm css3/filters/effect-sepia.html ietestcenter/css3/bordersbackgrounds/color-behind-images.htm virtual/gpu-rasterization/images/object-image.html images/png-color-profile-ignore-gamma.html mhtml/image_document.mht fast/css/background-shorthand-invalid-url.html css3/blending/background-blend-mode-different-image-formats.html css2.1/20110323/float-replaced-width-011.htm css2.1/20110323/absolute-replaced-height-030.htm css2.1/20110323/absolute-replaced-width-020.htm virtual/display_list_2d_canvas/fast/canvas/canvas-toDataURL-webp.html virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb.html fast/inline/inline-box-background-long-image.html css2.1/20110323/block-replaced-width-006.htm css2.1/20110323/absolute-replaced-width-064.htm css2.1/20110323/absolute-replaced-width-034.htm css2.1/20110323/absolute-replaced-height-016.htm virtual/spinvalidation/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem.html transforms/transformed-document-element.html css3/filters/effect-brightness-hw.html css3/filters/effect-saturate.html css3/filters/effect-hue-rotate.html css3/filters/effect-opacity-hw.html css2.1/20110323/absolute-replaced-height-010.htm css3/filters/effect-drop-shadow-hw.html virtual/display_list_2d_canvas/fast/canvas/canvas-toDataURL-webp-maximum-quality.html virtual/gpu/fast/canvas/canvas-toDataURL-webp-maximum-quality.html virtual/gpu-rasterization/images/paint-subrect.html css2.1/20110323/absolute-replaced-height-002.htm virtual/gpu/fast/canvas/canvas-toDataURL-jpeg-maximum-quality.html fast/canvas/canvas-toBlob-jpeg-medium-quality.html images/color-profile-image-profile-match.html fast/reflections/reflection-masks-outset.html css3/filters/regions-expanding.html virtual/layout_ng/css2.1/20110323/float-replaced-width-003.htm virtual/layout_ng/css2.1/20110323/float-replaced-width-001.htm virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb.html fast/canvas/canvas-toDataURL-webp-maximum-quality.html css2.1/20110323/inline-block-replaced-width-001.htm css2.1/20110323/absolute-replaced-width-036.htm css2.1/20110323/absolute-replaced-width-027.htm virtual/gpu/fast/canvas/canvas-toBlob-webp-maximum-quality.html ietestcenter/css3/bordersbackgrounds/order-of-images.htm css2.1/20110323/inline-replaced-width-001.htm css3/filters/crash-filter-change.html paint/invalidation/compositing/page-scale-repaint.html paint/invalidation/background-image-paint-invalidation-small-document.html virtual/layout_ng/css2.1/20110323/inline-replaced-width-001.htm ietestcenter/css3/bordersbackgrounds/background_position_three_four_values.htm css2.1/20110323/absolute-replaced-width-015.htm css3/filters/effect-blur.html css2.1/20110323/inline-replaced-height-001.htm svg/W3C-SVG-1.1/struct-image-08-t.svg css3/filters/effect-grayscale.html fast/canvas/canvas-toDataURL-jpeg-maximum-quality.html virtual/layout_ng/css2.1/20110323/block-replaced-width-001.htm css3/blending/mix-blend-mode-isolated-group-3.html css3/blending/background-blend-mode-default-value.html fast/writing-mode/block-level-images.html css2.1/20110323/absolute-replaced-width-057.htm css2.1/20110323/absolute-replaced-width-006.htm css3/blending/background-blend-mode-image-color.html ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio.htm fast/reflections/reflection-direction.html css2.1/20110323/absolute-replaced-height-024.htm css2.1/20110323/absolute-replaced-height-001.htm paint/invalidation/background-image-paint-invalidation-large-abspos-div.html virtual/threaded/compositing/visibility/visibility-image-layers.html css3/filters/effect-sepia-hw.html css2.1/20110323/block-replaced-height-001.htm images/color-profile-munsell-srgb-to-srgb.html css3/filters/effect-combined-hw.html virtual/layout_ng/css2.1/20110323/inline-replaced-height-001.htm css2.1/20110323/absolute-replaced-width-071.htm css2.1/20110323/absolute-replaced-width-013.htm css3/filters/effect-opacity.html css2.1/20110323/float-replaced-width-002.htm css3/blending/background-blend-mode-crossfade-image-gradient.html css2.1/20110323/inline-replaced-width-006.htm virtual/layout_ng/css2.1/20110323/block-replaced-width-006.htm css3/blending/background-blend-mode-gradient-image.html css2.1/20110323/inline-block-replaced-height-003.htm compositing/visibility/visibility-image-layers.html images/color-profile-munsell-adobe-to-srgb.html virtual/gpu-rasterization/images/png-color-profile-ignore-gamma.html css2.1/20110323/block-replaced-width-001.htm paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem.html css2.1/20110323/float-replaced-height-003.htm compositing/masks/direct-image-mask.html css3/blending/effect-background-blend-mode-tiled.html css2.1/20110323/absolute-replaced-width-001.htm virtual/layout_ng/css2.1/20110323/float-replaced-width-005.htm css2.1/20110323/width-replaced-element-001.htm Original issue's description: > Use more accurate sRGB, Adobe, matrices > > TBR=fmalita@chromium.org > > BUG=657839 > > Committed: https://crrev.com/556786009fd3fdbb395ab09432004a3afbc82b0c > Cr-Commit-Position: refs/heads/master@{#439209} TBR=fmalita@chromium.org,brianosman@google.com,msarett@chromium.org,msarett@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=657839 Committed: https://crrev.com/c4c784246439a5f5212f3047ecf098d6541171d1 Cr-Commit-Position: refs/heads/master@{#439259}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
rjkroege
Created Revert of Use more accurate sRGB, Adobe, matrices
4 years ago (2016-12-17 00:40:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580153002/1
4 years ago (2016-12-17 00:41:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-17 00:44:40 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-17 00:49:15 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c4c784246439a5f5212f3047ecf098d6541171d1
Cr-Commit-Position: refs/heads/master@{#439259}

Powered by Google App Engine
This is Rietveld 408576698