Ignore VR_EXTRA boolean in incoming Intent

Ignore VR_EXTRA boolean in incoming Intent

As explained in crbug.com/673019 We should just use DAYDREAM category
to detect if an Intent is a DAYDREAM Intent.

BUG=673019
Committed: https://crrev.com/203f0669b622c6425388c9d6fc7069dbbe451025
Cr-Commit-Position: refs/heads/master@{#440242}

[bshe, 2016-12-16 23:00:13]

bshe@chromium.org changed reviewers:
+ dtrainor@chromium.org, mthiesse@chromium.org

[bshe, 2016-12-16 23:00:13]

PTAL. Thanks!

[mthiesse, 2016-12-20 05:57:30]

This looks fine, but I'm not really clear on the purpose of this, even after
reading crbug.com/673019. If this is just cleanup to remove the cardboard
category, and redundant extra, then lgtm. Any app can still set the daydream
category and tell chrome to launch in VR though, so this doesn't change the fact
that another app can tell chrome to switch to VR/load a page in VR, right?

[bshe, 2016-12-20 13:40:46]

On 2016/12/20 05:57:30, mthiesse wrote:
> This looks fine, but I'm not really clear on the purpose of this, even after
> reading crbug.com/673019. If this is just cleanup to remove the cardboard
> category, and redundant extra, then lgtm. Any app can still set the daydream
> category and tell chrome to launch in VR though, so this doesn't change the
fact
> that another app can tell chrome to switch to VR/load a page in VR, right?

If an app specify Daydream category in the intent, it won't pass
ChromeLuncherActivity's
intent filter. So the intent wont reach CTA hence no VR.

[mthiesse, 2016-12-20 15:32:39]

lgtm

[David Trainor- moved to gerrit, 2016-12-21 07:58:33]

lgtm

[bshe, 2016-12-21 21:46:15]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2016-12-21 21:46:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 22:25:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482356775668820, "parent_rev":
"c083d7dac4a996434ab1c685535f34747e2d76fc", "commit_rev":
"8a3e7ca79b640d3f6a3e23e7039598abfb2a394f"}

[commit-bot: I haz the power, 2016-12-21 22:26:20]

Description was changed from

==========
Ignore VR_EXTRA boolean in incoming Intent


As explained in crbug.com/673019 We should just use DAYDREAM category
to detect if an Intent is a DAYDREAM Intent.

BUG=673019
==========

to

==========
Ignore VR_EXTRA boolean in incoming Intent


As explained in crbug.com/673019 We should just use DAYDREAM category
to detect if an Intent is a DAYDREAM Intent.

BUG=673019

Review-Url: https://codereview.chromium.org/2580093003
==========

[commit-bot: I haz the power, 2016-12-21 22:26:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-21 22:29:20]

Description was changed from

==========
Ignore VR_EXTRA boolean in incoming Intent


As explained in crbug.com/673019 We should just use DAYDREAM category
to detect if an Intent is a DAYDREAM Intent.

BUG=673019

Review-Url: https://codereview.chromium.org/2580093003
==========

to

==========
Ignore VR_EXTRA boolean in incoming Intent

As explained in crbug.com/673019 We should just use DAYDREAM category
to detect if an Intent is a DAYDREAM Intent.

BUG=673019

Committed: https://crrev.com/203f0669b622c6425388c9d6fc7069dbbe451025
Cr-Commit-Position: refs/heads/master@{#440242}
==========

[commit-bot: I haz the power, 2016-12-21 22:29:21]

Patchset 1 (id:??) landed as
https://crrev.com/203f0669b622c6425388c9d6fc7069dbbe451025
Cr-Commit-Position: refs/heads/master@{#440242}