Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2580093002: Revert of Convert USE_PROPRIETARY_CODECS to a buildflag header. (Closed)

Created:
4 years ago by rjkroege
Modified:
4 years ago
Reviewers:
brettw, xhwang
CC:
chromium-reviews, extensions-reviews_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, droger+watchlist_chromium.org, tommycli, Lei Zhang, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, jasonroberts+watch_google.com, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, imcheng+watch_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org, isheriff+watch_chromium.org, eme-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert USE_PROPRIETARY_CODECS to a buildflag header. (patchset #3 id:40001 of https://codereview.chromium.org/2572883002/ ) Reason for revert: best-guess fix for: /b/c/b/Android_Arm64_Builder__dbg_/src/buildtools/linux64/gn gen //out/Debug --check -> returned 1 ERROR at build arg file (use "gn args <out_dir>" to edit):1:19: Build argument has no effect. ffmpeg_branding = "Chrome" ^------- The variable "ffmpeg_branding" was set as a build argument but never appeared in a declare_args() block in any buildfile. Original issue's description: > Convert USE_PROPRIETARY_CODECS to a buildflag header. > > Convert the preprocessor define to a buildflag > //header defined in //media. The build arg is kept in //build/config/features.gni due to a dependency on WebRTC (described in a comment). > > R=xhwang@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/866e43b5348172572654dde22dfcf0556fe47d26 TBR=xhwang@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a5a337fc004c3c1ca3c6204d90d50bd063b70df3 Cr-Commit-Position: refs/heads/master@{#439219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -167 lines) Patch
M build/config/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/features.gni View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/icon_loader_chromeos.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/media/encrypted_media_browsertest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/media/encrypted_media_supported_types_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_content_client.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/media/chrome_key_systems.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M components/cdm/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/cdm/browser/cdm_message_filter_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/cdm/common/widevine_drm_delegate_android.cc View 2 chunks +1 line, -2 lines 0 comments Download
M components/cdm/renderer/android_key_systems.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/cdm/renderer/external_clear_key_key_system_properties.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M components/cdm/renderer/widevine_key_system_properties.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/media/media_browsertest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M content/browser/media/media_canplaytype_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_color_browsertest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/media/media_redirect_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/media/media_source_browsertest.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M media/BUILD.gn View 3 chunks +25 lines, -20 lines 0 comments Download
M media/base/audio_video_metadata_extractor_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M media/base/demuxer_perftest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/base/eme_constants.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/key_systems.cc View 6 chunks +7 lines, -8 lines 0 comments Download
M media/base/media_file_checker_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M media/base/mime_util_internal.cc View 6 chunks +6 lines, -7 lines 0 comments Download
M media/base/mime_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/webcontentdecryptionmodulesession_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/cast/sender/h264_vt_encoder_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M media/cdm/aes_decryptor.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M media/cdm/aes_decryptor_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M media/cdm/cdm_adapter_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M media/filters/audio_decoder_unittest.cc View 7 chunks +6 lines, -7 lines 0 comments Download
M media/filters/audio_file_reader_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_demuxer.h View 2 chunks +1 line, -2 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M media/filters/stream_parser_factory.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/test/pipeline_integration_perftest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 12 chunks +12 lines, -13 lines 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/widevine/cdm/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/widevine/cdm/widevine_cdm_common.h View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
rjkroege
Created Revert of Convert USE_PROPRIETARY_CODECS to a buildflag header.
4 years ago (2016-12-16 22:30:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580093002/1
4 years ago (2016-12-16 22:31:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 22:34:36 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-16 22:37:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5a337fc004c3c1ca3c6204d90d50bd063b70df3
Cr-Commit-Position: refs/heads/master@{#439219}

Powered by Google App Engine
This is Rietveld 408576698