Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2580083002: Remove MouseRelatedEvent (Closed)

Created:
4 years ago by dtapuska
Modified:
4 years ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MouseRelatedEvent Nobody uses mice anymore. No seriously there is only one subclass of MouseRelatedEvent... MouseEvent. Collapse them together. BUG=625684 Committed: https://crrev.com/e6889dbe1c0db9e519f9992f72ebfcd1e94af028 Cr-Commit-Position: refs/heads/master@{#439400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -419 lines) Patch
M third_party/WebKit/Source/core/events/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/MouseEvent.h View 3 chunks +76 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/MouseEvent.cpp View 7 chunks +209 lines, -13 lines 0 comments Download
D third_party/WebKit/Source/core/events/MouseRelatedEvent.h View 1 chunk +0 lines, -140 lines 0 comments Download
D third_party/WebKit/Source/core/events/MouseRelatedEvent.cpp View 1 chunk +0 lines, -257 lines 0 comments Download
M third_party/WebKit/Source/core/events/TouchEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dtapuska
4 years ago (2016-12-16 21:22:23 UTC) #2
bokan
lgtm
4 years ago (2016-12-18 21:11:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580083002/1
4 years ago (2016-12-19 01:16:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 03:49:49 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-19 03:51:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6889dbe1c0db9e519f9992f72ebfcd1e94af028
Cr-Commit-Position: refs/heads/master@{#439400}

Powered by Google App Engine
This is Rietveld 408576698