AppShell: Ignore channel requirements of extension API features

AppShell: Ignore channel requirements of extension API features

Make AppShell always the "unknown" channel, instead of always being "stable",
because (a) it doesn't have channels, (b) we want to test unstable APIs too, and
(c) saying app_shell is "dev channel" would be insulting to chrome dev channel.

This allows APIs like chrome.hid.getUserSelectedDevices to exist in app_shell. (That particular one crashes, but what can you do...)

BUG=none
R=steel@chromium.org

Review-Url: https://codereview.chromium.org/2580063003
Cr-Commit-Position: refs/heads/master@{#442748}
Committed: https://chromium.googlesource.com/chromium/src/+/1d1bf1cbc6c47fe45e286c84998f1ebf517d8946

[michaelpg, 2016-12-17 06:06:24]

Description was changed from

==========
AppShell: Ignore channel requirements of extension API features

Make AppShell always the "unknown" channel, instead of always being "stable",
because (a) it doesn't have channels, (b) we want to test unstable APIs too, and
(c) saying app_shell is "dev channel" would be insulting to chrome dev channel.

BUG=none
R=steel@chromium.org
==========

to

==========
AppShell: Ignore channel requirements of extension API features

Make AppShell always the "unknown" channel, instead of always being "stable",
because (a) it doesn't have channels, (b) we want to test unstable APIs too, and
(c) saying app_shell is "dev channel" would be insulting to chrome dev channel.

This allows APIs like chrome.hid.getUserSelectedDevices to exist in app_shell.
(That particular one crashes, but what can you do...)

BUG=none
R=steel@chromium.org
==========

[michaelpg, 2016-12-17 06:11:18]

https://codereview.chromium.org/2580063003/diff/1/extensions/common/features/...
File extensions/common/features/feature.h (left):

https://codereview.chromium.org/2580063003/diff/1/extensions/common/features/...
extensions/common/features/feature.h:153: void set_check_channel(bool
check_channel) { check_channel_ = check_channel; }
These are unused.

[Rahul Chaturvedi, 2017-01-09 18:22:45]

lgtm

[Devlin, 2017-01-09 23:55:05]

rdevlin.cronin@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Devlin, 2017-01-09 23:55:05]

lgtm

[michaelpg, 2017-01-10 23:53:46]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2017-01-10 23:53:47]

The patchset sent to the CQ was uploaded after l-g-t-m from steel@chromium.org,
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2580063003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-10 23:54:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 00:59:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484092426654040,
"parent_rev": "75527aec33e8bd011e19318962b9bf5610081a42", "commit_rev":
"1d1bf1cbc6c47fe45e286c84998f1ebf517d8946"}

[commit-bot: I haz the power, 2017-01-11 00:59:32]

Description was changed from

==========
AppShell: Ignore channel requirements of extension API features

Make AppShell always the "unknown" channel, instead of always being "stable",
because (a) it doesn't have channels, (b) we want to test unstable APIs too, and
(c) saying app_shell is "dev channel" would be insulting to chrome dev channel.

This allows APIs like chrome.hid.getUserSelectedDevices to exist in app_shell.
(That particular one crashes, but what can you do...)

BUG=none
R=steel@chromium.org
==========

to

==========
AppShell: Ignore channel requirements of extension API features

Make AppShell always the "unknown" channel, instead of always being "stable",
because (a) it doesn't have channels, (b) we want to test unstable APIs too, and
(c) saying app_shell is "dev channel" would be insulting to chrome dev channel.

This allows APIs like chrome.hid.getUserSelectedDevices to exist in app_shell.
(That particular one crashes, but what can you do...)

BUG=none
R=steel@chromium.org

Review-Url: https://codereview.chromium.org/2580063003
Cr-Commit-Position: refs/heads/master@{#442748}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d1bf1cbc6c47fe45e286c84998f...
==========

[commit-bot: I haz the power, 2017-01-11 00:59:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1d1bf1cbc6c47fe45e286c84998f...