Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2580043002: DevTools: improve go-to-file perceived latency: do not discard intermediate results. (Closed)

Created:
4 years ago by pfeldman
Modified:
4 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: improve go-to-file perceived latency: do not discard intermediate results. Committed: https://crrev.com/75a1d84f00c6df8b9d3eeef9bdb85e9bdc884351 Cr-Commit-Position: refs/heads/master@{#439635}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -15 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js View 3 chunks +33 lines, -15 lines 1 comment Download

Messages

Total messages: 15 (8 generated)
pfeldman
4 years ago (2016-12-16 20:25:12 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/2580043002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js File third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js (right): https://codereview.chromium.org/2580043002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js#newcode252 third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js:252: this._filteredItems = bestItems.concat(overflowItems).concat(filteredItems); we can speed this up ...
4 years ago (2016-12-16 22:26:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580043002/1
4 years ago (2016-12-16 23:21:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/356426)
4 years ago (2016-12-17 01:39:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580043002/1
4 years ago (2016-12-19 22:42:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 00:34:21 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-20 00:36:09 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75a1d84f00c6df8b9d3eeef9bdb85e9bdc884351
Cr-Commit-Position: refs/heads/master@{#439635}

Powered by Google App Engine
This is Rietveld 408576698