Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2580023002:
[Android History] Add a chrome://flags for the Android native history UI (Closed)
Description[Android History] Add a chrome://flags for the Android native history UI
BUG=654071
Committed: https://crrev.com/2cee23ab794a3ab5121a7b6f4a00e2961848775b
Cr-Commit-Position: refs/heads/master@{#439513}
Patch Set 1 #Patch Set 2 : [Android History] Add a chrome://flags for the Android native history UI #
Total comments: 2
Patch Set 3 : Fix indentation #Patch Set 4 : Add AndroidHistoryManager:enabled to LoginCustomFlags #Patch Set 5 : [Android History] Add a chrome://flags for the Android native history UI #Patch Set 6 : Rebase #
Messages
Total messages: 43 (29 generated)
The CQ bit was checked by twellington@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by twellington@chromium.org to run a CQ dry run
twellington@chromium.org changed reviewers: + dfalcantara@chromium.org
ptal
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2580023002/diff/20001/chrome/app/generated_re... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2580023002/diff/20001/chrome/app/generated_re... chrome/app/generated_resources.grd:15690: + <message name="IDS_NATIVE_ANDROID_HISTORY_MANAGER" desc="Name of the flag that enables the native Android history UI." translateable="false"> wonky indentation
https://codereview.chromium.org/2580023002/diff/20001/chrome/app/generated_re... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2580023002/diff/20001/chrome/app/generated_re... chrome/app/generated_resources.grd:15690: + <message name="IDS_NATIVE_ANDROID_HISTORY_MANAGER" desc="Name of the flag that enables the native Android history UI." translateable="false"> On 2016/12/16 18:14:22, dfalcantara (check my queue) wrote: > wonky indentation Done.
The CQ bit was checked by twellington@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dfalcantara@chromium.org Link to the patchset: https://codereview.chromium.org/2580023002/#ps7 (title: "Fix indentation")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by twellington@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
twellington@chromium.org changed reviewers: + holte@chromium.org
+holte - ptal at LoginCustomFlag addition in histograms.xml
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by twellington@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
histograms lgtm
The CQ bit was unchecked by twellington@chromium.org
The CQ bit was checked by twellington@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dfalcantara@chromium.org Link to the patchset: https://codereview.chromium.org/2580023002/#ps60001 (title: "[Android History] Add a chrome://flags for the Android native history UI")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by twellington@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for chrome/browser/about_flags.cc:
While running git apply --index -p1;
error: patch failed: chrome/browser/about_flags.cc:2102
error: chrome/browser/about_flags.cc: patch does not apply
Patch: chrome/browser/about_flags.cc
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index
21f2f41f6074ee80d01981c1e05c70196d272f50..4702d663e49c11f0fa3f01475d9b56a89f4971e8
100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -2102,6 +2102,11 @@ const FeatureEntry kFeatureEntries[] = {
IDS_FLAGS_CROS_COMP_UPDATES_DESCRIPTION, kOsCrOS,
FEATURE_VALUE_TYPE(features::kCrosCompUpdates)},
#endif
+#if defined(OS_ANDROID)
+ {"native-android-history-manager", IDS_NATIVE_ANDROID_HISTORY_MANAGER,
+ IDS_NATIVE_ANDROID_HISTORY_MANAGER_DESCRIPTION, kOsAndroid,
+ FEATURE_VALUE_TYPE(chrome::android::kNativeAndroidHistoryManager)},
+#endif
// NOTE: Adding new command-line switches requires adding corresponding
// entries to enum "LoginCustomFlags" in histograms.xml. See note in
The CQ bit was checked by twellington@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by twellington@chromium.org
The CQ bit was checked by twellington@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dfalcantara@chromium.org, holte@chromium.org Link to the patchset: https://codereview.chromium.org/2580023002/#ps80001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1482169329409030,
"parent_rev": "9fcdb327b3cef2b4cb4a0e8b60a3450842b701ac", "commit_rev":
"751d607e87fc97a773e27491856e99e2e5dd52ee"}
Message was sent while issue was closed.
Description was changed from ========== [Android History] Add a chrome://flags for the Android native history UI BUG=654071 ========== to ========== [Android History] Add a chrome://flags for the Android native history UI BUG=654071 Review-Url: https://codereview.chromium.org/2580023002 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [Android History] Add a chrome://flags for the Android native history UI BUG=654071 Review-Url: https://codereview.chromium.org/2580023002 ========== to ========== [Android History] Add a chrome://flags for the Android native history UI BUG=654071 Committed: https://crrev.com/2cee23ab794a3ab5121a7b6f4a00e2961848775b Cr-Commit-Position: refs/heads/master@{#439513} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/2cee23ab794a3ab5121a7b6f4a00e2961848775b Cr-Commit-Position: refs/heads/master@{#439513} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
