Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2579983002: [builtins] Compare sloppy arguments length with the correct backing store length (Closed)

Created:
4 years ago by Toon Verwaest
Modified:
4 years ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Compare sloppy arguments length with the correct backing store length BUG= Review-Url: https://codereview.chromium.org/2579983002 Cr-Commit-Position: refs/heads/master@{#41757} Committed: https://chromium.googlesource.com/v8/v8/+/3238b337c7b57cb8bf9da189e84ae5900f7b131a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/builtins/builtins-array.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
Toon Verwaest
ptal
4 years ago (2016-12-16 10:55:43 UTC) #4
Camillo Bruni
lgtm
4 years ago (2016-12-16 11:40:08 UTC) #8
Camillo Bruni
lgtm
4 years ago (2016-12-16 11:56:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579983002/1
4 years ago (2016-12-16 11:56:34 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-16 12:41:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3238b337c7b57cb8bf9da189e84ae5900f7...

Powered by Google App Engine
This is Rietveld 408576698