Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2579963002: Revert of Disallow passing a SharedArrayBuffer in the transfer list. (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Disallow passing a SharedArrayBuffer in the transfer list. (patchset #4 id:60001 of https://codereview.chromium.org/2570433005/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/12098 See: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > Disallow passing a SharedArrayBuffer in the transfer list. > > This behavior changed recently. SharedArrayBuffers should not be put in the > transfer list, because they are not detached, and that is the meaning of being > in the transfer list. > > This is the V8 side of the change, the Blink side will come next. > > Review-Url: https://codereview.chromium.org/2570433005 > Cr-Commit-Position: refs/heads/master@{#41740} > Committed: https://chromium.googlesource.com/v8/v8/+/1c5e1504e0305363cd262f1706cbd63f9a62ae46 TBR=jbroman@chromium.org,jkummerow@chromium.org,binji@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2579963002 Cr-Commit-Position: refs/heads/master@{#41744} Committed: https://chromium.googlesource.com/v8/v8/+/6932ea59042924d42a18c6fe9bcfa023d625c7f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -109 lines) Patch
M include/v8.h View 3 chunks +5 lines, -21 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/value-serializer.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/value-serializer.cc View 6 chunks +15 lines, -25 lines 0 comments Download
M test/unittests/value-serializer-unittest.cc View 7 chunks +14 lines, -50 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of Disallow passing a SharedArrayBuffer in the transfer list.
4 years ago (2016-12-16 07:34:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579963002/1
4 years ago (2016-12-16 07:34:33 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-16 07:34:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6932ea59042924d42a18c6fe9bcfa023d62...

Powered by Google App Engine
This is Rietveld 408576698