Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1769)

Issue 2579953002: Minor fixes for layout test writing documentation. (Closed)

Created:
4 years ago by pwnall
Modified:
4 years ago
Reviewers:
jsbell
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor fixes for layout test writing documentation. The main reason for this CL is to change the recommended path for accessing testharness.js from HTTP tests. The file can be accessed using both the old path (/js-test-resources/testharness.js) and the new path (/resources/testharness.js). However, our testharnessresult.js uses the CSS selector script[src*="/resources/testharness"] to identify JavaScript tests, causing tests that use the old path to fail without a text baseline. The CL also adds an "under construction" unicode character to the guideline for adding a <meta charset> to every test, as it is still under discussion. BUG= Committed: https://crrev.com/e781948d69c56ab6bfc89f318a1e107cb81a566f Cr-Commit-Position: refs/heads/master@{#439266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M docs/testing/writing_layout_tests.md View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
pwnall
PTAL? This is the line that I'm referencing: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/resources/testharnessreport.js?q=%22/resources/testharness%22+file:%5C.js&sq=package:chromium&l=88&dr=C This issue caused me to waste ...
4 years ago (2016-12-16 07:22:44 UTC) #2
jsbell
lgtm
4 years ago (2016-12-17 00:03:21 UTC) #3
pwnall
On 2016/12/17 00:03:21, jsbell wrote: > lgtm Thank you for the quick turnaround!
4 years ago (2016-12-17 00:45:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579953002/1
4 years ago (2016-12-17 00:45:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-17 00:59:22 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-17 01:02:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e781948d69c56ab6bfc89f318a1e107cb81a566f
Cr-Commit-Position: refs/heads/master@{#439266}

Powered by Google App Engine
This is Rietveld 408576698