Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2579893002: Revert "Add tab status to accessibility labels". (Closed)

Created:
4 years ago by Wez
Modified:
4 years ago
Reviewers:
edwardjung
CC:
chromium-reviews, tfarina, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add tab status to accessibility labels". This reverts https://codereview.chromium.org/2497373003, which caused a significant crasher in canary builds (see crbug.com/674334). TBR=edwardjung BUG=635610, 674334 Committed: https://crrev.com/c06c52eaf00f3d6482f438dcce1689e806880516 Cr-Commit-Position: refs/heads/master@{#438943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -145 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +2 lines, -54 lines 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 3 chunks +1 line, -18 lines 0 comments Download
M chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 7 chunks +9 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_renderer_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579893002/1
4 years ago (2016-12-15 21:54:40 UTC) #4
edwardjung
lgtm
4 years ago (2016-12-15 22:33:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 22:58:11 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-15 23:00:29 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c06c52eaf00f3d6482f438dcce1689e806880516
Cr-Commit-Position: refs/heads/master@{#438943}

Powered by Google App Engine
This is Rietveld 408576698