Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2579873002: gpu: Add missing entries for GPUInfo mojom. (Closed)

Created:
4 years ago by sadrul
Modified:
4 years ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Add missing entries for GPUInfo mojom. VideoDecodeAcceleratorCapabilities was missing the list of supported profiles. BUG=643746 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d4fe814b53e5be997b432644fb6cce2adff19898 Cr-Commit-Position: refs/heads/master@{#439047}

Patch Set 1 #

Patch Set 2 : test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M gpu/ipc/common/gpu_info.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/common/gpu_info_struct_traits.h View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/ipc/common/gpu_info_struct_traits.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/ipc/common/struct_traits_unittest.cc View 1 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 17 (12 generated)
sadrul
https://codereview.chromium.org/2579873002/diff/20001/gpu/ipc/common/struct_traits_unittest.cc File gpu/ipc/common/struct_traits_unittest.cc (right): https://codereview.chromium.org/2579873002/diff/20001/gpu/ipc/common/struct_traits_unittest.cc#newcode395 gpu/ipc/common/struct_traits_unittest.cc:395: gpu::VideoDecodeAcceleratorSupportedProfile()); I didn't set any attributes of these VideoDecodeAcceleratorSupportedProfile ...
4 years ago (2016-12-15 21:28:54 UTC) #7
Tom Sepez
lgtm
4 years ago (2016-12-15 23:33:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579873002/20001
4 years ago (2016-12-16 02:20:28 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 06:21:23 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-16 06:23:55 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4fe814b53e5be997b432644fb6cce2adff19898
Cr-Commit-Position: refs/heads/master@{#439047}

Powered by Google App Engine
This is Rietveld 408576698