chrome: Add support for custom crosh command.

chrome: Add support for custom crosh command.

This adds the "--crosh-command" command line switch that
cab be used to specify an alternative crosh command.

BUG=677267
TEST=chrome --crosh-command=/bin/bash

Review-Url: https://codereview.chromium.org/2579833005
Cr-Commit-Position: refs/heads/master@{#442767}
Committed: https://chromium.googlesource.com/chromium/src/+/de31123249d664dc1b9f96a924aa31b5d332a488

[reveman, 2017-01-10 04:25:52]

reveman@chromium.org changed reviewers:
+ benwells@chromium.org

[reveman, 2017-01-10 04:26:19]

Description was changed from

==========
chrome: Add support for custom crosh command.

This adds the "--crosh-command" command line switch that
cab be used to specify an alternative crosh command.

BUG=
TEST=chrome --crosh-commnad=/bin/bash
==========

to

==========
chrome: Add support for custom crosh command.

This adds the "--crosh-command" command line switch that
cab be used to specify an alternative crosh command.

BUG=677267
TEST=chrome --crosh-commnad=/bin/bash
==========

[benwells, 2017-01-10 22:25:07]

lgtm

https://codereview.chromium.org/2579833005/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/terminal/terminal_private_api.cc (right):

https://codereview.chromium.org/2579833005/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/terminal/terminal_private_api.cc:51: else
Nit: While here can you remove this else (no else after return).

[reveman, 2017-01-11 00:32:20]

Description was changed from

==========
chrome: Add support for custom crosh command.

This adds the "--crosh-command" command line switch that
cab be used to specify an alternative crosh command.

BUG=677267
TEST=chrome --crosh-commnad=/bin/bash
==========

to

==========
chrome: Add support for custom crosh command.

This adds the "--crosh-command" command line switch that
cab be used to specify an alternative crosh command.

BUG=677267
TEST=chrome --crosh-command=/bin/bash
==========

[reveman, 2017-01-11 00:33:00]

The CQ bit was checked by reveman@chromium.org

[reveman, 2017-01-11 00:33:01]

https://codereview.chromium.org/2579833005/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/terminal/terminal_private_api.cc (right):

https://codereview.chromium.org/2579833005/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/terminal/terminal_private_api.cc:51: else
On 2017/01/10 at 22:25:07, benwells wrote:
> Nit: While here can you remove this else (no else after return).

Done.

[reveman, 2017-01-11 00:33:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org
Link to the patchset: https://codereview.chromium.org/2579833005/#ps20001
(title: "remove else")

[commit-bot: I haz the power, 2017-01-11 00:34:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 01:48:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484094780843200,
"parent_rev": "536b626025606ce4ecca3f2595d384cd4b947ebe", "commit_rev":
"de31123249d664dc1b9f96a924aa31b5d332a488"}

[commit-bot: I haz the power, 2017-01-11 01:49:11]

Description was changed from

==========
chrome: Add support for custom crosh command.

This adds the "--crosh-command" command line switch that
cab be used to specify an alternative crosh command.

BUG=677267
TEST=chrome --crosh-command=/bin/bash
==========

to

==========
chrome: Add support for custom crosh command.

This adds the "--crosh-command" command line switch that
cab be used to specify an alternative crosh command.

BUG=677267
TEST=chrome --crosh-command=/bin/bash

Review-Url: https://codereview.chromium.org/2579833005
Cr-Commit-Position: refs/heads/master@{#442767}
Committed:
https://chromium.googlesource.com/chromium/src/+/de31123249d664dc1b9f96a924aa...
==========

[commit-bot: I haz the power, 2017-01-11 01:49:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/de31123249d664dc1b9f96a924aa...