Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2579833002: Use MarginLayoutParams in ToolbarManager (Closed)

Created:
4 years ago by mdjones
Modified:
4 years ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use MarginLayoutParams in ToolbarManager The control container can have different parent views depending on which flags are enabled, namely Chrome Home. This change removes the assumption that particular layout params are for a FrameLayout and instead uses the least common denominator -- MarginLayoutParams. This should be fine in this case since the margin is all that is being modified. BUG=664985 Committed: https://crrev.com/91df9834a095460208c7bbf0fcd3747c18eab64d Cr-Commit-Position: refs/heads/master@{#438900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
mdjones
Read my code
4 years ago (2016-12-15 18:08:37 UTC) #2
gone
Read. lgtm
4 years ago (2016-12-15 18:56:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579833002/1
4 years ago (2016-12-15 19:18:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 19:54:25 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-15 19:56:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91df9834a095460208c7bbf0fcd3747c18eab64d
Cr-Commit-Position: refs/heads/master@{#438900}

Powered by Google App Engine
This is Rietveld 408576698