Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2579793002: Set number of shards for telemetry_unittests to be 2 (Closed)

Created:
4 years ago by nednguyen
Modified:
4 years ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set number of shards for telemetry_unittests to be 2 This suite currently occasionally is timed out (its usual runtime is 20 minutes total), causing flaky failure BUG=661434 Committed: https://crrev.com/45cada6244d0cc9c8798e6531d2c1ea0b90a5668 Cr-Commit-Position: refs/heads/master@{#438859}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -16 lines) Patch
M testing/buildbot/chromium.fyi.json View 6 chunks +18 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 3 chunks +9 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 4 chunks +12 lines, -4 lines 0 comments Download
M testing/buildbot/chromium.win.json View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
nednguyen
4 years ago (2016-12-15 14:43:01 UTC) #2
M-A Ruel
lgtm, 20 minutes is too long anyway.
4 years ago (2016-12-15 14:50:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579793002/1
4 years ago (2016-12-15 14:52:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/357090)
4 years ago (2016-12-15 16:07:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579793002/1
4 years ago (2016-12-15 16:08:49 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 17:30:12 UTC) #17
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/45cada6244d0cc9c8798e6531d2c1ea0b90a5668 Cr-Commit-Position: refs/heads/master@{#438859}
4 years ago (2016-12-15 17:32:56 UTC) #19
Dirk Pranke
lgtm
4 years ago (2016-12-15 17:45:20 UTC) #20
Kunihiko Sakamoto
4 years ago (2016-12-16 07:26:36 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2583703003/ by ksakamoto@chromium.org.

The reason for reverting is: telemetry_unittests failing on chromium.linux/Linux
Tests (dbg)(1) and linux_chromium_rel_ng.
https://crbug.com/674788.

Powered by Google App Engine
This is Rietveld 408576698