Use int for fgetc() result in headless_shell

Use int for fgetc() result in headless_shell

Fixes compilation failure introduced by c3ac4fc0.

fgetc() returns its result as an _unsigned_ char and defines EOF as -1, and
gives the result as an int.  If char is unsigned it's impossible for EOF to
match, and this results in a compilation error.  If char is signed then
potentially valid input could match EOF.

BUG=674765
R=altimin@chromium.org, skyostil@chromium.org

Change-Id: I979a8401e8c33d8983e7d1bee96b81bc555863ec
Committed: https://crrev.com/b43d478991126401b0a03ef49438fcdcda961938
Cr-Commit-Position: refs/heads/master@{#439479}

[Simon Hosie, 2016-12-16 02:44:57]

Note that this patch triggers the following presubmit message:

These files spam the console log with LOG(INFO):
  headless/app/headless_shell.cc

[cavalcantii1, 2016-12-16 02:46:30]

The CQ bit was checked by cavalcantii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 02:47:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-12-16 02:57:01]

On 2016/12/16 02:44:57, Simon Hosie wrote:
> Note that this patch triggers the following presubmit message:
> 
> These files spam the console log with LOG(INFO):
>   headless/app/headless_shell.cc

Someone should add it to the blacklist in
https://cs.chromium.org/chromium/src/PRESUBMIT.py?q=%22These+files+spam+the+c...
to fix that

[commit-bot: I haz the power, 2016-12-16 04:42:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 04:42:43]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sami, 2016-12-16 15:11:06]

lgtm, thank you for the fix!

On 2016/12/16 02:57:01, Nico (out Thu Dec 15) wrote:
> On 2016/12/16 02:44:57, Simon Hosie wrote:
> > Note that this patch triggers the following presubmit message:
> > 
> > These files spam the console log with LOG(INFO):
> >   headless/app/headless_shell.cc
> 
> Someone should add it to the blacklist in
>
https://cs.chromium.org/chromium/src/PRESUBMIT.py?q=%22These+files+spam+the+c...
> to fix that

Thanks for the tip; doing that here: https://codereview.chromium.org/2581643004/

[Sami, 2016-12-19 15:18:28]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2016-12-19 15:18:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 15:50:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482160708885780, "parent_rev":
"1e5d7c0c14e9fd54d3d89ebdc3a30f38311d01c3", "commit_rev":
"9ab0f3b7eda9f8873563412aa416f703f3d7e950"}

[commit-bot: I haz the power, 2016-12-19 15:51:00]

Description was changed from

==========
Use int for fgetc() result in headless_shell

Fixes compilation failure introduced by c3ac4fc0.

fgetc() returns its result as an _unsigned_ char and defines EOF as -1, and
gives the result as an int.  If char is unsigned it's impossible for EOF to
match, and this results in a compilation error.  If char is signed then
potentially valid input could match EOF.

BUG=674765
R=altimin@chromium.org, skyostil@chromium.org

Change-Id: I979a8401e8c33d8983e7d1bee96b81bc555863ec
==========

to

==========
Use int for fgetc() result in headless_shell

Fixes compilation failure introduced by c3ac4fc0.

fgetc() returns its result as an _unsigned_ char and defines EOF as -1, and
gives the result as an int.  If char is unsigned it's impossible for EOF to
match, and this results in a compilation error.  If char is signed then
potentially valid input could match EOF.

BUG=674765
R=altimin@chromium.org, skyostil@chromium.org

Change-Id: I979a8401e8c33d8983e7d1bee96b81bc555863ec
Review-Url: https://codereview.chromium.org/2579773003
==========

[commit-bot: I haz the power, 2016-12-19 15:51:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-19 15:52:44]

Description was changed from

==========
Use int for fgetc() result in headless_shell

Fixes compilation failure introduced by c3ac4fc0.

fgetc() returns its result as an _unsigned_ char and defines EOF as -1, and
gives the result as an int.  If char is unsigned it's impossible for EOF to
match, and this results in a compilation error.  If char is signed then
potentially valid input could match EOF.

BUG=674765
R=altimin@chromium.org, skyostil@chromium.org

Change-Id: I979a8401e8c33d8983e7d1bee96b81bc555863ec
Review-Url: https://codereview.chromium.org/2579773003
==========

to

==========
Use int for fgetc() result in headless_shell

Fixes compilation failure introduced by c3ac4fc0.

fgetc() returns its result as an _unsigned_ char and defines EOF as -1, and
gives the result as an int.  If char is unsigned it's impossible for EOF to
match, and this results in a compilation error.  If char is signed then
potentially valid input could match EOF.

BUG=674765
R=altimin@chromium.org, skyostil@chromium.org

Change-Id: I979a8401e8c33d8983e7d1bee96b81bc555863ec
Committed: https://crrev.com/b43d478991126401b0a03ef49438fcdcda961938
Cr-Commit-Position: refs/heads/master@{#439479}
==========

[commit-bot: I haz the power, 2016-12-19 15:52:45]

Patchset 1 (id:??) landed as
https://crrev.com/b43d478991126401b0a03ef49438fcdcda961938
Cr-Commit-Position: refs/heads/master@{#439479}