Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2579743002: [turbofan] Handle the impossible value representation mismatch in instruction selector. (Closed)

Created:
4 years ago by Jarin
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Handle the impossible value representation mismatch in instruction selector. Review-Url: https://codereview.chromium.org/2579743002 Cr-Commit-Position: refs/heads/master@{#41718} Committed: https://chromium.googlesource.com/v8/v8/+/01de216fd7eadedc95bc4b8a772e97a2968905c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -15 lines) Patch
M src/compiler/instruction-selector.cc View 3 chunks +35 lines, -15 lines 0 comments Download
A test/mjsunit/compiler/regress-674469.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Jarin
Could you take a look, please?
4 years ago (2016-12-15 11:47:40 UTC) #4
Benedikt Meurer
lgtm
4 years ago (2016-12-15 11:50:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579743002/1
4 years ago (2016-12-15 11:51:00 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-15 12:13:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/01de216fd7eadedc95bc4b8a772e97a2968...

Powered by Google App Engine
This is Rietveld 408576698