[Autofill] Update credit card icons to match payments.

Update credit card icons to match payments.

"""
MasterCard recently updated their logo
https://brand.mastercard.com/brandcenter/mastercard-brand-mark/downloads.html
with these guidelines
https://brand.mastercard.com/brandcenter/mastercard-brand-mark.html
"""

BUG=None
New icons are from https://spec.googleplex.com/payments/resources/icons-logos.html#icons-logos-icons

Committed: https://crrev.com/1a5cc3aee6308158cf93ac50bbf2dc116cee8ebf
Cr-Commit-Position: refs/heads/master@{#439133}

[csashi, 2016-12-15 18:24:59]

Description was changed from

==========
Revert change to suppress IconXmlAndPng lint error.


Update credit card icons to match payments.

uses SVG for amex, mastercard and visa

updates discover card PNG files. SVG for discover card fails with
../../chrome/android/java/res/drawable/discover_card.xml:92: error: Error:
String types not allowed (at 'fillColor' with value 'url(#linearGradient-3)')

uses SVG for amex, mastercard and visa

Generate vector for discover card using
http://a-student.github.io/SvgToVectorDrawableConverter.Web/ and
--fix-fill-type. Results in 'o' of 'Discover' being filled with black instead of
orange.

Manually replaces fillColor=url(#linearGradient-3) with #F68221

Update discover card for acceptance marks to not specify gradient.

Update discover card for acceptance marks to not specify gradient.

Adds icons for diners and JCB and opaque photo camera.

Adds icons for diners and JCB and opaque photo camera.

Uses new assets for HTTP and HTTPS warnings.

Adds vector drawables for HTTP and HTTPS warning icons in autofill.

Switches generic_card to vector drawable. Adds copyrights.

Remove vector drawable for diners_card and jcb_card because they are too big.
Uses generic card icon for these 2 cards.

Restore files that git has marked as modified instead of deleted.

deletes files that git has marked as modified instead of deleted.

Renames getIconId to getVectorDrawableIconId to make it clear that the icon has
to be a vector. Updates AutofillKeyboardAccessory to use VectorDrawableCompat.

Renames getIconId to getVectorDrawableIconId to make it clear that the icon has
to be a vector. Updates AutofillKeyboardAccessory to use VectorDrawableCompat.

Renames getIconId to getVectorDrawableIconId to make it clear that the icon has
to be a vector. Updates AutofillKeyboardAccessory to use VectorDrawableCompat.

Renames getIconId to getVectorDrawableIconId to make it clear that the icon has
to be a vector. Updates AutofillKeyboardAccessory to use VectorDrawableCompat.

Use Drawable for setCompoundDrawablesRelativeWithIntrinsicBounds

Fixes dimensions of camera and generic card icons.

Fixes dimensions of settings icon displayed in KeyboardAccessoryView.

Fixes dimensions of info and warning icons.

Fixes card icons to remove grey stroke at the 4 edges of the rectangle.

Add discover_card to see if subsequent delete marks it as 'M' in
codereview.chromium.org

Add discover_card to see if subsequent delete marks it as 'D' in
codereview.chromium.org

Add discover_card to see if subsequent delete marks it as 'D' in
codereview.chromium.org

Try git rm -rf.

Add IconXmlAndPng for files that have been deleted but marked as 'M' in
codereview.chromium.org

BUG=
==========

to

==========
Update credit card icons


BUG=
==========

[csashi, 2016-12-15 18:25:00]

csashi@google.com changed reviewers:
+ dtrainor@chromium.org, estade@chromium.org, jochen@chromium.org

[csashi, 2016-12-15 18:26:07]

Hi,
This issue is identical to https://codereview.chromium.org/2551683002/ which was
reviewed and approved. However, because of a bug in the code repository tool
(https://bugs.chromium.org/p/chromium/issues/detail?id=674606) CQ failed. As a
workaround, I am uploading a new CL with the same changes.

Apologies for the additional work imposed on the reviewers but could not find
any other workaround.

[Mathieu, 2016-12-15 18:56:25]

mathp@chromium.org changed reviewers:
+ mathp@chromium.org

[Mathieu, 2016-12-15 18:56:26]

lgtm

[Mathieu, 2016-12-15 18:57:01]

Description was changed from

==========
Update credit card icons


BUG=
==========

to

==========
Update credit card icons to match payments.

"""
MasterCard recently updated their logo
https://brand.mastercard.com/brandcenter/mastercard-brand-mark/downloads.html
with these guidelines
https://brand.mastercard.com/brandcenter/mastercard-brand-mark.html
"""

New icons are from
https://spec.googleplex.com/payments/resources/icons-logos.html#icons-logos-i...
==========

[Mathieu, 2016-12-15 18:58:09]

Description was changed from

==========
Update credit card icons to match payments.

"""
MasterCard recently updated their logo
https://brand.mastercard.com/brandcenter/mastercard-brand-mark/downloads.html
with these guidelines
https://brand.mastercard.com/brandcenter/mastercard-brand-mark.html
"""

New icons are from
https://spec.googleplex.com/payments/resources/icons-logos.html#icons-logos-i...
==========

to

==========
Update credit card icons to match payments.

"""
MasterCard recently updated their logo
https://brand.mastercard.com/brandcenter/mastercard-brand-mark/downloads.html
with these guidelines
https://brand.mastercard.com/brandcenter/mastercard-brand-mark.html
"""

BUG=None
New icons are from
https://spec.googleplex.com/payments/resources/icons-logos.html#icons-logos-i...
==========

[David Trainor- moved to gerrit, 2016-12-15 19:25:00]

rubber stamp lgtm.

[jochen (gone - plz use gerrit), 2016-12-16 09:24:34]

lgtm

[Mathieu, 2016-12-16 14:38:01]

mathp@chromium.org changed reviewers:
- estade@chromium.org

[Mathieu, 2016-12-16 14:38:16]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2016-12-16 14:38:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 16:35:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 16:35:37]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Mathieu, 2016-12-16 16:45:18]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2016-12-16 16:46:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 17:24:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481906718698470, "parent_rev":
"8d657e7468142c15eda37b3200e8ed9caee7c80a", "commit_rev":
"0bdaf8eaab846fc1466c955656dcc3ad6fc31b4d"}

[commit-bot: I haz the power, 2016-12-16 17:25:28]

Description was changed from

==========
Update credit card icons to match payments.

"""
MasterCard recently updated their logo
https://brand.mastercard.com/brandcenter/mastercard-brand-mark/downloads.html
with these guidelines
https://brand.mastercard.com/brandcenter/mastercard-brand-mark.html
"""

BUG=None
New icons are from
https://spec.googleplex.com/payments/resources/icons-logos.html#icons-logos-i...
==========

to

==========
Update credit card icons to match payments.

"""
MasterCard recently updated their logo
https://brand.mastercard.com/brandcenter/mastercard-brand-mark/downloads.html
with these guidelines
https://brand.mastercard.com/brandcenter/mastercard-brand-mark.html
"""

BUG=None
New icons are from
https://spec.googleplex.com/payments/resources/icons-logos.html#icons-logos-i...

Review-Url: https://codereview.chromium.org/2579623003
==========

[commit-bot: I haz the power, 2016-12-16 17:25:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-16 17:28:29]

Description was changed from

==========
Update credit card icons to match payments.

"""
MasterCard recently updated their logo
https://brand.mastercard.com/brandcenter/mastercard-brand-mark/downloads.html
with these guidelines
https://brand.mastercard.com/brandcenter/mastercard-brand-mark.html
"""

BUG=None
New icons are from
https://spec.googleplex.com/payments/resources/icons-logos.html#icons-logos-i...

Review-Url: https://codereview.chromium.org/2579623003
==========

to

==========
Update credit card icons to match payments.

"""
MasterCard recently updated their logo
https://brand.mastercard.com/brandcenter/mastercard-brand-mark/downloads.html
with these guidelines
https://brand.mastercard.com/brandcenter/mastercard-brand-mark.html
"""

BUG=None
New icons are from
https://spec.googleplex.com/payments/resources/icons-logos.html#icons-logos-i...

Committed: https://crrev.com/1a5cc3aee6308158cf93ac50bbf2dc116cee8ebf
Cr-Commit-Position: refs/heads/master@{#439133}
==========

[commit-bot: I haz the power, 2016-12-16 17:28:30]

Patchset 1 (id:??) landed as
https://crrev.com/1a5cc3aee6308158cf93ac50bbf2dc116cee8ebf
Cr-Commit-Position: refs/heads/master@{#439133}

[Ted C, 2017-01-03 19:03:37]

tedchoc@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ted C, 2017-01-03 19:03:38]

https://codereview.chromium.org/2579623003/diff/1/ui/android/java/src/org/chr...
File ui/android/java/src/org/chromium/ui/DropdownAdapter.java (right):

https://codereview.chromium.org/2579623003/diff/1/ui/android/java/src/org/chr...
ui/android/java/src/org/chromium/ui/DropdownAdapter.java:179:
iconView.setImageDrawable(VectorDrawableCompat.create(mContext.getResources(),
I don't think this was a safe change to make.

In particular, Autofill uses non-vector drawables in their dropdown, and this at
a minimum breaks it and could potentially cause a crash if it doesn't work as
expected.

In general, I think you should revert the name back to getIconId() and handle
vector or not vectors here.

I "think" this is a way that would inflate a vector drawable or a bitmap for you
without you having to know the resource type:

https://developer.android.com/reference/android/support/v7/content/res/AppCom...,
int)

[csashi, 2017-01-03 19:32:09]

https://codereview.chromium.org/2579623003/diff/1/ui/android/java/src/org/chr...
File ui/android/java/src/org/chromium/ui/DropdownAdapter.java (right):

https://codereview.chromium.org/2579623003/diff/1/ui/android/java/src/org/chr...
ui/android/java/src/org/chromium/ui/DropdownAdapter.java:179:
iconView.setImageDrawable(VectorDrawableCompat.create(mContext.getResources(),
On 2017/01/03 19:03:38, Ted C wrote:
> I don't think this was a safe change to make.
> 
> In particular, Autofill uses non-vector drawables in their dropdown, and this
at
> a minimum breaks it and could potentially cause a crash if it doesn't work as
> expected.
> 
> In general, I think you should revert the name back to getIconId() and handle
> vector or not vectors here.
> 
> I "think" this is a way that would inflate a vector drawable or a bitmap for
you
> without you having to know the resource type:
> 
>
https://developer.android.com/reference/android/support/v7/content/res/AppCom...,
> int)

I switched all the resources Autofill uses to vector drawables. Do you know of
any resource that Autofill uses and is not a vector drawable?

[Ted C, 2017-01-03 21:01:43]

On 2017/01/03 19:32:09, csashi wrote:
>
https://codereview.chromium.org/2579623003/diff/1/ui/android/java/src/org/chr...
> File ui/android/java/src/org/chromium/ui/DropdownAdapter.java (right):
> 
>
https://codereview.chromium.org/2579623003/diff/1/ui/android/java/src/org/chr...
> ui/android/java/src/org/chromium/ui/DropdownAdapter.java:179:
> iconView.setImageDrawable(VectorDrawableCompat.create(mContext.getResources(),
> On 2017/01/03 19:03:38, Ted C wrote:
> > I don't think this was a safe change to make.
> > 
> > In particular, Autofill uses non-vector drawables in their dropdown, and
this
> at
> > a minimum breaks it and could potentially cause a crash if it doesn't work
as
> > expected.
> > 
> > In general, I think you should revert the name back to getIconId() and
handle
> > vector or not vectors here.
> > 
> > I "think" this is a way that would inflate a vector drawable or a bitmap for
> you
> > without you having to know the resource type:
> > 
> >
>
https://developer.android.com/reference/android/support/v7/content/res/AppCom...,
> > int)
> 
> I switched all the resources Autofill uses to vector drawables. Do you know of
> any resource that Autofill uses and is not a vector drawable?

From this code review I got:
https://codereview.chromium.org/2548753002/diff/100001/chrome/android/java/sr...

It looks like we use: omnibox_info and omnibox_https_invalid.  Both are things
that are used throughout the code base and I don't think I would recommend
switching to vectors (without measuring performance impact).

[csashi, 2017-01-03 21:09:59]

On 2017/01/03 21:01:43, Ted C wrote:
> On 2017/01/03 19:32:09, csashi wrote:
> >
>
https://codereview.chromium.org/2579623003/diff/1/ui/android/java/src/org/chr...
> > File ui/android/java/src/org/chromium/ui/DropdownAdapter.java (right):
> > 
> >
>
https://codereview.chromium.org/2579623003/diff/1/ui/android/java/src/org/chr...
> > ui/android/java/src/org/chromium/ui/DropdownAdapter.java:179:
> >
iconView.setImageDrawable(VectorDrawableCompat.create(mContext.getResources(),
> > On 2017/01/03 19:03:38, Ted C wrote:
> > > I don't think this was a safe change to make.
> > > 
> > > In particular, Autofill uses non-vector drawables in their dropdown, and
> this
> > at
> > > a minimum breaks it and could potentially cause a crash if it doesn't work
> as
> > > expected.
> > > 
> > > In general, I think you should revert the name back to getIconId() and
> handle
> > > vector or not vectors here.
> > > 
> > > I "think" this is a way that would inflate a vector drawable or a bitmap
for
> > you
> > > without you having to know the resource type:
> > > 
> > >
> >
>
https://developer.android.com/reference/android/support/v7/content/res/AppCom...,
> > > int)
> > 
> > I switched all the resources Autofill uses to vector drawables. Do you know
of
> > any resource that Autofill uses and is not a vector drawable?
> 
> From this code review I got:
>
https://codereview.chromium.org/2548753002/diff/100001/chrome/android/java/sr...
> 
> It looks like we use: omnibox_info and omnibox_https_invalid.  Both are things
> that are used throughout the code base and I don't think I would recommend
> switching to vectors (without measuring performance impact).

I did not switch omnibox icons to vectors because they were used extensively. I
switched the use of icons in auto fill code as follows:
omnibox_info -> ic_info_outline_black.xml
omnibox_https_invalid -> ic_warning_black.xml

[Ted C, 2017-01-03 21:24:33]

On 2017/01/03 21:09:59, csashi wrote:
> On 2017/01/03 21:01:43, Ted C wrote:
> > On 2017/01/03 19:32:09, csashi wrote:
> > >
> >
>
https://codereview.chromium.org/2579623003/diff/1/ui/android/java/src/org/chr...
> > > File ui/android/java/src/org/chromium/ui/DropdownAdapter.java (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2579623003/diff/1/ui/android/java/src/org/chr...
> > > ui/android/java/src/org/chromium/ui/DropdownAdapter.java:179:
> > >
> iconView.setImageDrawable(VectorDrawableCompat.create(mContext.getResources(),
> > > On 2017/01/03 19:03:38, Ted C wrote:
> > > > I don't think this was a safe change to make.
> > > > 
> > > > In particular, Autofill uses non-vector drawables in their dropdown, and
> > this
> > > at
> > > > a minimum breaks it and could potentially cause a crash if it doesn't
work
> > as
> > > > expected.
> > > > 
> > > > In general, I think you should revert the name back to getIconId() and
> > handle
> > > > vector or not vectors here.
> > > > 
> > > > I "think" this is a way that would inflate a vector drawable or a bitmap
> for
> > > you
> > > > without you having to know the resource type:
> > > > 
> > > >
> > >
> >
>
https://developer.android.com/reference/android/support/v7/content/res/AppCom...,
> > > > int)
> > > 
> > > I switched all the resources Autofill uses to vector drawables. Do you
know
> of
> > > any resource that Autofill uses and is not a vector drawable?
> > 
> > From this code review I got:
> >
>
https://codereview.chromium.org/2548753002/diff/100001/chrome/android/java/sr...
> > 
> > It looks like we use: omnibox_info and omnibox_https_invalid.  Both are
things
> > that are used throughout the code base and I don't think I would recommend
> > switching to vectors (without measuring performance impact).
> 
> I did not switch omnibox icons to vectors because they were used extensively.
I
> switched the use of icons in auto fill code as follows:
> omnibox_info -> ic_info_outline_black.xml
> omnibox_https_invalid -> ic_warning_black.xml

Ah ha...got it.  I see it updated in resource_id.h.  So I guess that should
be fine.

I still don't think we should specify that the drawable id is a vector and
that should be a hidden implementation detail, but that isn't broken and is
a nice to have cleanup.

I don't think vectors support tinting though, so it will likely collide with
the other change but this change didn't break anything.  Sorry for the noise.