Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2579623002:
[DXVAVDA] Dump without crashing on EXCEPTION_DEBUG_EVENT (Closed)
|
Created:
4 years ago by jbauman Modified:
4 years ago Reviewers:
sandersd (OOO until July 31) CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DXVAVDA] Dump without crashing on EXCEPTION_DEBUG_EVENT
It's unclear what's causing this, but the current instrumentation seems
to show this ExceptionCode is the last one received before a hang.
BUG=636158, 613701
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/1104899ce2fcb512e2df2600b455fbe1f8ffc056
Cr-Commit-Position: refs/heads/master@{#438887}
Patch Set 1 #Patch Set 2 : change to EXCEPTION_DEBUG_EVENT #Messages
Total messages: 21 (15 generated)
Description was changed from ========== [DXVAVDA] Dump without crashing if exception has ExceptionCode 1 It's unclear what's causing this, but the current instrumentation seems to show this ExceptionCode is the last one received before a hang. BUG=636158, 613701 ========== to ========== [DXVAVDA] Dump without crashing if exception has ExceptionCode 1 It's unclear what's causing this, but the current instrumentation seems to show this ExceptionCode is the last one received before a hang. BUG=636158, 613701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by jbauman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by jbauman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [DXVAVDA] Dump without crashing if exception has ExceptionCode 1 It's unclear what's causing this, but the current instrumentation seems to show this ExceptionCode is the last one received before a hang. BUG=636158, 613701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [DXVAVDA] Dump without crashing on EXCEPTION_DEBUG_EVENT It's unclear what's causing this, but the current instrumentation seems to show this ExceptionCode is the last one received before a hang. BUG=636158, 613701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
jbauman@chromium.org changed reviewers: + sandersd@chromium.org
I'm not sure whether this is EXCEPTION_DEBUG_EVENT, or just 1, but either way it's pretty weird.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by jbauman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481828826411490,
"parent_rev": "3b08a3e84f8252c005ce278e2ae7672c9bab7384", "commit_rev":
"cea108b9fc45ad16bf7691e6075340c3cac50ebb"}
Message was sent while issue was closed.
Description was changed from ========== [DXVAVDA] Dump without crashing on EXCEPTION_DEBUG_EVENT It's unclear what's causing this, but the current instrumentation seems to show this ExceptionCode is the last one received before a hang. BUG=636158, 613701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== [DXVAVDA] Dump without crashing on EXCEPTION_DEBUG_EVENT It's unclear what's causing this, but the current instrumentation seems to show this ExceptionCode is the last one received before a hang. BUG=636158, 613701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2579623002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [DXVAVDA] Dump without crashing on EXCEPTION_DEBUG_EVENT It's unclear what's causing this, but the current instrumentation seems to show this ExceptionCode is the last one received before a hang. BUG=636158, 613701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2579623002 ========== to ========== [DXVAVDA] Dump without crashing on EXCEPTION_DEBUG_EVENT It's unclear what's causing this, but the current instrumentation seems to show this ExceptionCode is the last one received before a hang. BUG=636158, 613701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/1104899ce2fcb512e2df2600b455fbe1f8ffc056 Cr-Commit-Position: refs/heads/master@{#438887} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1104899ce2fcb512e2df2600b455fbe1f8ffc056 Cr-Commit-Position: refs/heads/master@{#438887}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2591593002/ by jbauman@chromium.org. The reason for reverting is: We have enough crash dumps for now, so reverting so this doesn't prevent the hang dumps from uploading due to rate limiting.. |
